You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/29 12:37:15 UTC
[GitHub] [dolphinscheduler] Chris-Arith opened a new pull request, #12218: create oracle help.md
Chris-Arith opened a new pull request, #12218:
URL: https://github.com/apache/dolphinscheduler/pull/12218
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
help for using oracle datasource
<!--(For example: This pull request adds checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Chris-Arith commented on a diff in pull request #12218: create oracle help.md
Posted by GitBox <gi...@apache.org>.
Chris-Arith commented on code in PR #12218:
URL: https://github.com/apache/dolphinscheduler/pull/12218#discussion_r990579034
##########
docs/docs/zh/guide/datasource/oracle.md:
##########
@@ -0,0 +1,12 @@
+
Review Comment:
pls check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #12218: [doc] create oracle help.md
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #12218:
URL: https://github.com/apache/dolphinscheduler/pull/12218#issuecomment-1272845095
@Chris-Arith can you correct the document and change the screenshots to English version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Chris-Arith commented on pull request #12218: create oracle help.md
Posted by GitBox <gi...@apache.org>.
Chris-Arith commented on PR #12218:
URL: https://github.com/apache/dolphinscheduler/pull/12218#issuecomment-1272443431
> Can you add the corresponding English document? @Chris-Arith
OK, I will do it ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Chris-Arith commented on pull request #12218: [doc] create oracle help.md
Posted by GitBox <gi...@apache.org>.
Chris-Arith commented on PR #12218:
URL: https://github.com/apache/dolphinscheduler/pull/12218#issuecomment-1272989716
> @Chris-Arith can you correct the document and change the screenshots to English version?
Copy that, I will fix it in next PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] davidzollo merged pull request #12218: create oracle help.md
Posted by GitBox <gi...@apache.org>.
davidzollo merged PR #12218:
URL: https://github.com/apache/dolphinscheduler/pull/12218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fuchanghai commented on pull request #12218: create oracle help.md
Posted by GitBox <gi...@apache.org>.
fuchanghai commented on PR #12218:
URL: https://github.com/apache/dolphinscheduler/pull/12218#issuecomment-1272437715
Can you add the corresponding English document? @Chris-Arith
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] davidzollo commented on pull request #12218: create oracle help.md
Posted by GitBox <gi...@apache.org>.
davidzollo commented on PR #12218:
URL: https://github.com/apache/dolphinscheduler/pull/12218#issuecomment-1272815454
> > Can you add the corresponding English document? @Chris-Arith
>
> OK, I will do it ASAP.
good job, thanks for your first contribution.
By the way, please update the picture `https://user-images.githubusercontent.com/48941586/193031878-d7c35140-fe12-4d45-a0b9-a70dc018d25f.png` in English environment when you submit next pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org