You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/08/27 17:00:26 UTC

[GitHub] [cordova-plugin-test-framework] zachawilson opened a new pull request #56: (android) allow insecure requests for test results communication

zachawilson opened a new pull request #56:
URL: https://github.com/apache/cordova-plugin-test-framework/pull/56


   ### Platforms affected
   - android
   
   
   ### Motivation and Context
   Allowing insecure (HTTP) is necessary for `cordova-paramedic` to work, because the `cordova-plugin-test-framework` scripts running in the cordova environment, need to post (HTTP PUT) test results to the local server of `cordova-paramedic`, awaiting the results.
   
   To address the need for insecure (HTTP) is why `plugin.xml` is updated to enable both `AndroidInsecureFileModeEnabled=true` and `android:usesCleartextTraffic=true`.
   
   
   
   ### Description
   Updated configuration in `plugin.xml` of this project to allow android to make insecure (HTTP) requests.
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-plugin-test-framework] zachawilson commented on pull request #56: (android) allow insecure requests for test results communication

Posted by GitBox <gi...@apache.org>.
zachawilson commented on pull request #56:
URL: https://github.com/apache/cordova-plugin-test-framework/pull/56#issuecomment-907445408


   @dpogue via the cordova Slack channel I found https://github.com/erisu/cordova-paramedic/compare/feat/gh-actions
   
   The approach that @erisu took is probably better, because this "fix" is specific to `cordova-paramedic` and @erisu solution was done within https://github.com/apache/cordova-paramedic
   
   So I'm going to close this PR and try to get one opened against https://github.com/apache/cordova-paramedic directly


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-plugin-test-framework] zachawilson closed pull request #56: (android) allow insecure requests for test results communication

Posted by GitBox <gi...@apache.org>.
zachawilson closed pull request #56:
URL: https://github.com/apache/cordova-plugin-test-framework/pull/56


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-plugin-test-framework] zachawilson commented on pull request #56: (android) allow insecure requests for test results communication

Posted by GitBox <gi...@apache.org>.
zachawilson commented on pull request #56:
URL: https://github.com/apache/cordova-plugin-test-framework/pull/56#issuecomment-907454570


   What I was trying to do with this PR is superseded by:
   https://github.com/apache/cordova-paramedic/pull/215


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org