You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/02 16:59:48 UTC
[GitHub] [shardingsphere] codecov-io edited a comment on pull request #5412: Decouple sharding data source name and master slave name
codecov-io edited a comment on pull request #5412:
URL: https://github.com/apache/shardingsphere/pull/5412#issuecomment-622980950
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5412?src=pr&el=h1) Report
> Merging [#5412](https://codecov.io/gh/apache/shardingsphere/pull/5412?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/38ebec49401445c75f0f809ec1ce59ed6cc91441&el=desc) will **decrease** coverage by `0.12%`.
> The diff coverage is `13.75%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/5412?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5412 +/- ##
============================================
- Coverage 53.96% 53.84% -0.13%
Complexity 419 419
============================================
Files 1160 1161 +1
Lines 20832 20861 +29
Branches 3766 3770 +4
============================================
- Hits 11243 11233 -10
- Misses 8874 8913 +39
Partials 715 715
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5412?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...sphere/encrypt/metadata/EncryptMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/5412/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvbWV0YWRhdGEvRW5jcnlwdE1ldGFEYXRhTG9hZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...pache/shardingsphere/encrypt/rule/EncryptRule.java](https://codecov.io/gh/apache/shardingsphere/pull/5412/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcnVsZS9FbmNyeXB0UnVsZS5qYXZh) | `72.13% <0.00%> (-1.21%)` | `0.00 <0.00> (ø)` | |
| [...ngsphere/core/metadata/ShardingMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/5412/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9tZXRhZGF0YS9TaGFyZGluZ01ldGFEYXRhTG9hZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ache/shardingsphere/core/rule/MasterSlaveRule.java](https://codecov.io/gh/apache/shardingsphere/pull/5412/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9ydWxlL01hc3RlclNsYXZlUnVsZS5qYXZh) | `53.12% <0.00%> (-12.26%)` | `0.00 <0.00> (ø)` | |
| [...rg/apache/shardingsphere/core/rule/ShadowRule.java](https://codecov.io/gh/apache/shardingsphere/pull/5412/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9ydWxlL1NoYWRvd1J1bGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...mmon/metadata/schema/RuleSchemaMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/5412/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL21ldGFkYXRhL3NjaGVtYS9SdWxlU2NoZW1hTWV0YURhdGFMb2FkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ingsphere/underlying/common/rule/DataNodeUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/5412/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL3J1bGUvRGF0YU5vZGVVdGlsLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ardingsphere/underlying/common/rule/DataNodes.java](https://codecov.io/gh/apache/shardingsphere/pull/5412/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL3J1bGUvRGF0YU5vZGVzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/shardingsphere/core/rule/ShardingRule.java](https://codecov.io/gh/apache/shardingsphere/pull/5412/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9ydWxlL1NoYXJkaW5nUnVsZS5qYXZh) | `70.70% <23.07%> (-5.38%)` | `0.00 <0.00> (ø)` | |
| [...org/apache/shardingsphere/core/rule/TableRule.java](https://codecov.io/gh/apache/shardingsphere/pull/5412/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9ydWxlL1RhYmxlUnVsZS5qYXZh) | `88.88% <75.00%> (+8.60%)` | `1.00 <0.00> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/shardingsphere/pull/5412/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5412?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5412?src=pr&el=footer). Last update [38ebec4...1fb6714](https://codecov.io/gh/apache/shardingsphere/pull/5412?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org