You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/03/17 17:14:22 UTC
[GitHub] [systemds] ChristofJ95 opened a new pull request #1204: WIP
ChristofJ95 opened a new pull request #1204:
URL: https://github.com/apache/systemds/pull/1204
Das Hauptproblem, welches wir derzeit haben liegt darin das wir nicht verstehen, warum der Parameter „cur_small_nodes“ = 0 ist. Während wir glauben, dass wir das Binning richtig initialisieren, auch die entsprechende Matrix zurückgeben, wird dennoch kein "small node" gefunden. Folglich wird die perform schleife in Zeile 741 ausgeführt mit 1:0 was einen Error wirft. Wir haben ebenfalls die gesamte parfor in eine if Abfrage gegeben, welche bei dem Fall, dass "cur_num_small_nodes = 0" ist die gesamte parfor überspringt dennoch werden weitere Errors geworfen.
Beim Debuggen haben wir herausgefunden das „cur_num_small_nodes“ von „cur_max_I_gain“ abhängt. Dieses wiederrum hängt von „I_gain_portion“ usw. ab. Am Ende haben wir uns komplett darin verloren herauszufinden an welchem Parameter es am Endeffekt wirklich liegt.
Zusatzbemerkung:
Die implementierte Binning funktion wurde von uns zum Zwecke des debuggings extrem vereinfacht und auf 2 while schleifen geändert. In der originalen, haben wir alles innerhalb einer while schleife berechnet (Mittels arithmetischem Mittel) und zurückgegeben, zum Zwecke der Errorsuche haben wir diese vereinfacht um mögliche Fehler schneller zu finden.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] mboehm7 commented on pull request #1204: [WIP] RandomForest.dml implementation
Posted by GitBox <gi...@apache.org>.
mboehm7 commented on pull request #1204:
URL: https://github.com/apache/systemds/pull/1204#issuecomment-812938097
Also, this script was/is certainly one of the most convoluted ones, so don't feel bad about not fully completing it. We appreciate your effort. I now also have a plan to rework this and make it much easier to understand (and hopefully faster too).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] mboehm7 commented on pull request #1204: [WIP] RandomForest.dml implementation
Posted by GitBox <gi...@apache.org>.
mboehm7 commented on pull request #1204:
URL: https://github.com/apache/systemds/pull/1204#issuecomment-812936341
LGTM. Thanks for the initial builtin function and cleanups @ChristofJ95 and team. I now did some additional cleanups (running junit test, test script, builtin function registration, docs cleanup, replaced equi-height binning with quantile).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] ChristofJ95 closed pull request #1204: WIP
Posted by GitBox <gi...@apache.org>.
ChristofJ95 closed pull request #1204:
URL: https://github.com/apache/systemds/pull/1204
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] asfgit closed pull request #1204: [WIP] RandomForest.dml implementation
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1204:
URL: https://github.com/apache/systemds/pull/1204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org