You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "davsclaus (via GitHub)" <gi...@apache.org> on 2023/08/23 07:36:25 UTC
[GitHub] [camel] davsclaus opened a new pull request, #11181: Camel19772
davsclaus opened a new pull request, #11181:
URL: https://github.com/apache/camel/pull/11181
# Description
<!--
- Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
-->
# Target
- [ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [ ] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on a diff in pull request #11181: Camel19772
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on code in PR #11181:
URL: https://github.com/apache/camel/pull/11181#discussion_r1302688228
##########
core/camel-xml-io/src/main/java/org/apache/camel/xml/LwModelToXMLDumper.java:
##########
@@ -258,4 +283,55 @@ private static NamespaceAware getNamespaceAwareFromExpression(ExpressionNode exp
return na;
}
+ private static class BeanModelWriter implements CamelContextAware {
+
+ private final StringWriter buffer;
+ private CamelContext camelContext;
+
+ public BeanModelWriter(StringWriter buffer) {
+ this.buffer = buffer;
+ }
+
+ @Override
+ public CamelContext getCamelContext() {
+ return camelContext;
+ }
+
+ @Override
+ public void setCamelContext(CamelContext camelContext) {
+ this.camelContext = camelContext;
+ }
+
+ public void start() {
+ // noop
+ }
+
+ public void stop() {
+ // noop
+ }
+
+ public void writeBeans(List<RegistryBeanDefinition> beans) {
+ if (beans.isEmpty()) {
+ return;
+ }
+ for (RegistryBeanDefinition b : beans) {
+ doWriteRegistryBeanDefinition(b);
+ }
+ }
+
+ private void doWriteRegistryBeanDefinition(RegistryBeanDefinition b) {
+ buffer.write(String.format(" <bean name=\"%s\" type=\"%s\">%n", b.getName(), b.getType()));
+ if (b.getProperties() != null && !b.getProperties().isEmpty()) {
+ buffer.write(String.format(" <properties>%n"));
+ for (Map.Entry<String, Object> entry : b.getProperties().entrySet()) {
+ String key = entry.getKey();
+ Object value = entry.getValue();
+ buffer.write(String.format(" <property key=\"%s\" value=\"%s\"/>%n", key, value));
+ }
+ buffer.write(String.format(" </properties>%n"));
+ }
+ buffer.write(String.format(" </bean>%n"));
+ }
+ }
Review Comment:
I created a ticket to take note and simplify the discussion: https://issues.apache.org/jira/browse/CAMEL-19779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #11181: Camel19772
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #11181:
URL: https://github.com/apache/camel/pull/11181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #11181: Camel19772
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11181:
URL: https://github.com/apache/camel/pull/11181#issuecomment-1689442305
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
:robot: Use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on a diff in pull request #11181: Camel19772
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on code in PR #11181:
URL: https://github.com/apache/camel/pull/11181#discussion_r1302680683
##########
core/camel-xml-io/src/main/java/org/apache/camel/xml/LwModelToXMLDumper.java:
##########
@@ -258,4 +283,55 @@ private static NamespaceAware getNamespaceAwareFromExpression(ExpressionNode exp
return na;
}
+ private static class BeanModelWriter implements CamelContextAware {
+
+ private final StringWriter buffer;
+ private CamelContext camelContext;
+
+ public BeanModelWriter(StringWriter buffer) {
+ this.buffer = buffer;
+ }
+
+ @Override
+ public CamelContext getCamelContext() {
+ return camelContext;
+ }
+
+ @Override
+ public void setCamelContext(CamelContext camelContext) {
+ this.camelContext = camelContext;
+ }
+
+ public void start() {
+ // noop
+ }
+
+ public void stop() {
+ // noop
+ }
+
+ public void writeBeans(List<RegistryBeanDefinition> beans) {
+ if (beans.isEmpty()) {
+ return;
+ }
+ for (RegistryBeanDefinition b : beans) {
+ doWriteRegistryBeanDefinition(b);
+ }
+ }
+
+ private void doWriteRegistryBeanDefinition(RegistryBeanDefinition b) {
+ buffer.write(String.format(" <bean name=\"%s\" type=\"%s\">%n", b.getName(), b.getType()));
+ if (b.getProperties() != null && !b.getProperties().isEmpty()) {
+ buffer.write(String.format(" <properties>%n"));
+ for (Map.Entry<String, Object> entry : b.getProperties().entrySet()) {
+ String key = entry.getKey();
+ Object value = entry.getValue();
+ buffer.write(String.format(" <property key=\"%s\" value=\"%s\"/>%n", key, value));
+ }
+ buffer.write(String.format(" </properties>%n"));
+ }
+ buffer.write(String.format(" </bean>%n"));
+ }
+ }
Review Comment:
@davsclaus this is a little bit off-topic but, I think it's something we should start thinking about for the future (maybe we'll need to create a ticket about it).
We have a lot of places with code-to-be-generated that are built-in in the code base. IMHO, this is extremely hard to read, maintain and debug. At some point in 4.x, I believe, we should start investigating how to move this to some kind of template library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org