You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sanjay Tripathi <sa...@citrix.com> on 2013/05/08 10:44:07 UTC

Review Request: CLOUDSTACK-1603 : Management server .log Java Exceptions are displayed with Alerts

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11004/
-----------------------------------------------------------

Review request for cloudstack, Devdeep Singh, Likitha Shetty, and Sateesh Chodapuneedi.


Description
-------

CLOUDSTACK-1603 : Management server .log Java Exceptions are displayed with Alerts


This addresses bug CLOUDSTACK-1603.


Diffs
-----

  engine/storage/volume/src/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java f2cb1c4 

Diff: https://reviews.apache.org/r/11004/diff/


Testing
-------

Tested on my local CloudStack setup.


Thanks,

Sanjay Tripathi


Re: Review Request: CLOUDSTACK-1603 : Management server .log Java Exceptions are displayed with Alerts

Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11004/#review20299
-----------------------------------------------------------



engine/storage/volume/src/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java
<https://reviews.apache.org/r/11004/#comment41833>

    Can you update the message too to be more informative? I don't think we need to surface the name of the internal command that has failed in the alert message.


- Devdeep Singh


On May 8, 2013, 8:44 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11004/
> -----------------------------------------------------------
> 
> (Updated May 8, 2013, 8:44 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Likitha Shetty, and Sateesh Chodapuneedi.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1603 : Management server .log Java Exceptions are displayed with Alerts
> 
> 
> This addresses bug CLOUDSTACK-1603.
> 
> 
> Diffs
> -----
> 
>   engine/storage/volume/src/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java f2cb1c4 
> 
> Diff: https://reviews.apache.org/r/11004/diff/
> 
> 
> Testing
> -------
> 
> Tested on my local CloudStack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request: CLOUDSTACK-1603 : Management server .log Java Exceptions are displayed with Alerts

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11004/#review20412
-----------------------------------------------------------


Commit 3aed20c9d27cbe97afc32fd47909a2f08c4550c8 in branch refs/heads/master from Pranav Saxena <pr...@citrix.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3aed20c ]

CLOUDSTACK-1603: Management server .log Java Exceptions are displayed with Alerts


- ASF Subversion and Git Services


On May 8, 2013, 9:35 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11004/
> -----------------------------------------------------------
> 
> (Updated May 8, 2013, 9:35 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Likitha Shetty, and Sateesh Chodapuneedi.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1603 : Management server .log Java Exceptions are displayed with Alerts
> 
> 
> This addresses bug CLOUDSTACK-1603.
> 
> 
> Diffs
> -----
> 
>   engine/storage/volume/src/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java f2cb1c4 
> 
> Diff: https://reviews.apache.org/r/11004/diff/
> 
> 
> Testing
> -------
> 
> Tested on my local CloudStack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request: CLOUDSTACK-1603 : Management server .log Java Exceptions are displayed with Alerts

Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11004/#review20315
-----------------------------------------------------------

Ship it!


Ship It!

- Devdeep Singh


On May 8, 2013, 9:35 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11004/
> -----------------------------------------------------------
> 
> (Updated May 8, 2013, 9:35 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Likitha Shetty, and Sateesh Chodapuneedi.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1603 : Management server .log Java Exceptions are displayed with Alerts
> 
> 
> This addresses bug CLOUDSTACK-1603.
> 
> 
> Diffs
> -----
> 
>   engine/storage/volume/src/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java f2cb1c4 
> 
> Diff: https://reviews.apache.org/r/11004/diff/
> 
> 
> Testing
> -------
> 
> Tested on my local CloudStack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request: CLOUDSTACK-1603 : Management server .log Java Exceptions are displayed with Alerts

Posted by Sanjay Tripathi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11004/
-----------------------------------------------------------

(Updated May 8, 2013, 9:35 a.m.)


Review request for cloudstack, Devdeep Singh, Likitha Shetty, and Sateesh Chodapuneedi.


Changes
-------

Updated patch.


Description
-------

CLOUDSTACK-1603 : Management server .log Java Exceptions are displayed with Alerts


This addresses bug CLOUDSTACK-1603.


Diffs (updated)
-----

  engine/storage/volume/src/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java f2cb1c4 

Diff: https://reviews.apache.org/r/11004/diff/


Testing
-------

Tested on my local CloudStack setup.


Thanks,

Sanjay Tripathi


Re: Review Request: CLOUDSTACK-1603 : Management server .log Java Exceptions are displayed with Alerts

Posted by Sanjay Tripathi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11004/
-----------------------------------------------------------

(Updated May 8, 2013, 8:58 a.m.)


Review request for cloudstack, Devdeep Singh, Likitha Shetty, and Sateesh Chodapuneedi.


Changes
-------

Updated patch as per review comment.


Description
-------

CLOUDSTACK-1603 : Management server .log Java Exceptions are displayed with Alerts


This addresses bug CLOUDSTACK-1603.


Diffs (updated)
-----

  engine/storage/volume/src/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java f2cb1c4 

Diff: https://reviews.apache.org/r/11004/diff/


Testing
-------

Tested on my local CloudStack setup.


Thanks,

Sanjay Tripathi