You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by ganeshmurthy <gi...@git.apache.org> on 2016/05/20 17:02:38 UTC
[GitHub] qpid-dispatch pull request: DISPATCH-341 - Added drain support for...
GitHub user ganeshmurthy opened a pull request:
https://github.com/apache/qpid-dispatch/pull/76
DISPATCH-341 - Added drain support for message routes and link routes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-341
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/76.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #76
----
commit bdd8462c2ee4040123584d1ca876cd4e95dd14d0
Author: Ganesh Murthy <gm...@redhat.com>
Date: 2016-05-20T16:59:48Z
DISPATCH-341 - Added drain support for message routes and link routes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request: DISPATCH-341 - Added drain support for...
Posted by ted-ross <gi...@git.apache.org>.
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/76#discussion_r64077033
--- Diff: src/router_core/connections.c ---
@@ -188,7 +188,10 @@ int qdr_connection_process(qdr_connection_t *conn)
sys_mutex_unlock(conn->work_lock);
if (link) {
- core->flow_handler(core->user_context, link, link->incremental_credit);
+ if (link->drain_mode)
+ core->drained_handler(core->user_context, link);
+ else
--- End diff --
What happens if there is credit _and_ drain mode? Does the credit not get issued?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #76: DISPATCH-341 - Added drain support for messa...
Posted by ganeshmurthy <gi...@git.apache.org>.
Github user ganeshmurthy closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/76
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request: DISPATCH-341 - Added drain support for...
Posted by ganeshmurthy <gi...@git.apache.org>.
Github user ganeshmurthy commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/76#discussion_r64082133
--- Diff: src/router_core/connections.c ---
@@ -188,7 +188,10 @@ int qdr_connection_process(qdr_connection_t *conn)
sys_mutex_unlock(conn->work_lock);
if (link) {
- core->flow_handler(core->user_context, link, link->incremental_credit);
+ if (link->drain_mode)
+ core->drained_handler(core->user_context, link);
+ else
--- End diff --
I removed the else and made it 2 if statements
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org