You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "nodece (via GitHub)" <gi...@apache.org> on 2024/01/17 11:27:36 UTC
[PR] [fix][client] Producer uses pulsar-client-internal thread to execute callback [pulsar]
nodece opened a new pull request, #21913:
URL: https://github.com/apache/pulsar/pull/21913
Fixes #21900
### Motivation
In #21900, I guess the user uses a sync call in the `pulsar-client-io` callback thread, so throw the timeout exception.
The `pulsar-client-io` thread is used to communicate between the broker and the client, when `pulsar-client-io` is stuck, the timeout exception will be thrown.
If we switch from the `pulsar-client-io` to the `pulsar-client-internal` thread to execute the callback, #21900 will be fixed.
In the consumer, there's a similar approach：
https://github.com/apache/pulsar/blob/252509e08018eeed189e0d5492c3664a67bced06/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java#L471-L487
### Modifications
- Producers always use the `pulsar-client-internal` thread to execute the callback.
### Verifying this change
`ProducerCallbackThreadTest` has been added.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][client] Producer uses pulsar-client-internal thread to execute callback [pulsar]
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #21913:
URL: https://github.com/apache/pulsar/pull/21913#issuecomment-1895779730
Some tests fail when multiple threads are used to execute callbacks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][client] Producer uses pulsar-client-internal thread to execute callback [pulsar]
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece closed pull request #21913: [fix][client] Producer uses pulsar-client-internal thread to execute callback
URL: https://github.com/apache/pulsar/pull/21913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][client] Producer uses pulsar-client-internal thread to execute callback [pulsar]
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #21913:
URL: https://github.com/apache/pulsar/pull/21913#issuecomment-1895780037
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][client] Producer uses pulsar-client-internal thread to execute callback [pulsar]
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece closed pull request #21913: [fix][client] Producer uses pulsar-client-internal thread to execute callback
URL: https://github.com/apache/pulsar/pull/21913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org