You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xuchuanyin <gi...@git.apache.org> on 2018/02/03 08:42:44 UTC
[GitHub] carbondata pull request #1920: [CARBONDATA-2110] Remove tempCsv option in te...
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/1920
[CARBONDATA-2110] Remove tempCsv option in test cases
Since 'TempCSV' option is deprecated in PR #1916 ,
1. the tests using this option should also be updated.
2. log warn message about this deprecated option if user still use it.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [X] Any interfaces changed?
`NO`
- [X] Any backward compatibility impacted?
`NO`
- [x] Document update required?
`NO`
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
`Deleted the corresponding tests about tempcsv option`
- How it is tested? Please attach test report.
`Tested it local machine`
- Is it a performance related change? Please attach the performance test report.
`No`
- Any additional information to help reviewers in testing this change.
`NO`
- [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
`Not related`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xuchuanyin/carbondata 0201_deprecate_temp_csv_option
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1920.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1920
----
commit 4a0ad4f16c904c9d49f50b3dc0919dd86d962076
Author: xuchuanyin <xu...@...>
Date: 2018-02-03T08:29:46Z
Remove tempCsv option in test cases
----
---
[GitHub] carbondata pull request #1920: [CARBONDATA-2110] Remove tempCsv option in te...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1920#discussion_r165810022
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDataFrameWriter.scala ---
@@ -42,6 +42,10 @@ class CarbonDataFrameWriter(sqlContext: SQLContext, val dataFrame: DataFrame) {
private def writeToCarbonFile(parameters: Map[String, String] = Map()): Unit = {
val options = new CarbonOption(parameters)
+ if (options.tempCSV) {
--- End diff --
OK.
move this deprecate information to `CarbonOptions`
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1920
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3359/
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1920
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2900/
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1920
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4074/
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1920
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3968/
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1920
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3512/
---
[GitHub] carbondata pull request #1920: [CARBONDATA-2110] Remove tempCsv option in te...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin closed the pull request at:
https://github.com/apache/carbondata/pull/1920
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1920
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2246/
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1920
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4226/
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1920
retest this please
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1920
LGTM
---
[GitHub] carbondata pull request #1920: [CARBONDATA-2110] Remove tempCsv option in te...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1920#discussion_r165809918
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDataFrameWriter.scala ---
@@ -42,6 +42,10 @@ class CarbonDataFrameWriter(sqlContext: SQLContext, val dataFrame: DataFrame) {
private def writeToCarbonFile(parameters: Map[String, String] = Map()): Unit = {
val options = new CarbonOption(parameters)
+ if (options.tempCSV) {
--- End diff --
please add a comment in CarbonOptions.tempCSV to describe it is deprecated. And remove CarbonOptions.compress
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1920
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2981/
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1920
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2828/
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1920
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4144/
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1920
@jackylk done
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1920
@xuchuanyin master is freeze before 1.3 release. I will merge this after some time
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1920
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3344/
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1920
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3125/
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1920
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3479/
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1920
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3772/
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1920
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3043/
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1920
retest this please
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1920
retest this please
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1920
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2238/
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1920
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4287/
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1920
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3487/
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1920
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5178/
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1920
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3806/
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1920
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4359/
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1920
please rebase
---
[GitHub] carbondata issue #1920: [CARBONDATA-2110] Remove tempCsv option in test case...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1920
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2275/
---