You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "sergeyuttsel (via GitHub)" <gi...@apache.org> on 2023/06/15 22:03:37 UTC
[GitHub] [ignite-3] sergeyuttsel opened a new pull request, #2201: IGNITE-19736 Do not cancel tasks in DistributionZoneManager#executor if they were created by immediate scaleUp/scaleDown events. Avoid concurrent executing several tasks for the same zone.
sergeyuttsel opened a new pull request, #2201:
URL: https://github.com/apache/ignite-3/pull/2201
https://issues.apache.org/jira/browse/IGNITE-19736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2201: IGNITE-19736 Do not cancel tasks in DistributionZoneManager#executor if they were created by immediate scaleUp/scaleDown events. Avoid concurrent executing several tasks for the same zone.
Posted by "sergeyuttsel (via GitHub)" <gi...@apache.org>.
sergeyuttsel commented on code in PR #2201:
URL: https://github.com/apache/ignite-3/pull/2201#discussion_r1242545958
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -282,8 +282,10 @@ public DistributionZoneManager(
nodesAttributes = new ConcurrentHashMap<>();
+ // Use a single thread executor to avoid concurrent executing several tasks for the same zone.
+ // TODO: IGNITE-19783 Need to use a striped executor.
Review Comment:
I agree. Moved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2201: IGNITE-19736 Do not cancel tasks in DistributionZoneManager#executor if they were created by immediate scaleUp/scaleDown events. Avoid concurrent executing several tasks for the same zone.
Posted by "sergeyuttsel (via GitHub)" <gi...@apache.org>.
sergeyuttsel commented on code in PR #2201:
URL: https://github.com/apache/ignite-3/pull/2201#discussion_r1233697235
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerScaleUpTest.java:
##########
@@ -307,312 +301,6 @@ void testDropZoneDoNotPropagateDataNodesAfterScaleDown() throws Exception {
assertZoneScaleDownChangeTriggerKey(null, ZONE_1_ID, keyValueStorage);
}
- @Test
- void testTwoScaleUpTimersSecondTimerRunFirst() throws Exception {
Review Comment:
This is a permanent solution. My algorithm needs a guarantee that tasks of each zone will be executed in the order they were added to the executor. These tests check that multiple tasks for a zone are running at the same time, so now such tests will not pass successfully. Even if I make a striped executor, it won't change this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] alievmirza commented on a diff in pull request #2201: IGNITE-19736 Do not cancel tasks in DistributionZoneManager#executor if they were created by immediate scaleUp/scaleDown events. Avoid concurrent executing several tasks for the same zone.
Posted by "alievmirza (via GitHub)" <gi...@apache.org>.
alievmirza commented on code in PR #2201:
URL: https://github.com/apache/ignite-3/pull/2201#discussion_r1242432274
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -282,8 +282,10 @@ public DistributionZoneManager(
nodesAttributes = new ConcurrentHashMap<>();
+ // Use a single thread executor to avoid concurrent executing several tasks for the same zone.
+ // TODO: IGNITE-19783 Need to use a striped executor.
Review Comment:
Let's move creation of the executor to a util method in DistributionZonesUtil snd reuse in test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sk0x50 merged pull request #2201: IGNITE-19736 Do not cancel tasks in DistributionZoneManager#executor if they were created by immediate scaleUp/scaleDown events. Avoid concurrent executing several tasks for the same zone.
Posted by "sk0x50 (via GitHub)" <gi...@apache.org>.
sk0x50 merged PR #2201:
URL: https://github.com/apache/ignite-3/pull/2201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] alievmirza commented on a diff in pull request #2201: IGNITE-19736 Do not cancel tasks in DistributionZoneManager#executor if they were created by immediate scaleUp/scaleDown events. Avoid concurrent executing several tasks for the same zone.
Posted by "alievmirza (via GitHub)" <gi...@apache.org>.
alievmirza commented on code in PR #2201:
URL: https://github.com/apache/ignite-3/pull/2201#discussion_r1233604855
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerScaleUpTest.java:
##########
@@ -307,312 +301,6 @@ void testDropZoneDoNotPropagateDataNodesAfterScaleDown() throws Exception {
assertZoneScaleDownChangeTriggerKey(null, ZONE_1_ID, keyValueStorage);
}
- @Test
- void testTwoScaleUpTimersSecondTimerRunFirst() throws Exception {
Review Comment:
Is this a temporary solution? If yes, why did we delete this tests, not mute?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org