You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Benedikt Ritter (Created) (JIRA)" <ji...@apache.org> on 2012/03/16 15:03:39 UTC
[jira] [Created] (CSV-69) Eliminate
CSVPrinterTest.equals(String[][], String[][]) by using
Assert.assertArrayEquals
Eliminate CSVPrinterTest.equals(String[][], String[][]) by using Assert.assertArrayEquals
-----------------------------------------------------------------------------------------
Key: CSV-69
URL: https://issues.apache.org/jira/browse/CSV-69
Project: Commons CSV
Issue Type: Test
Reporter: Benedikt Ritter
CSVPrinterTest uses an equals method to compare two dimensional String arrays. Since the project has been updated to JUnit 4, Assert.assertArrayEquals() can be used instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CSV-69) Eliminate
CSVPrinterTest.equals(String[][], String[][]) by using
Assert.assertArrayEquals
Posted by "Benedikt Ritter (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CSV-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231593#comment-13231593 ]
Benedikt Ritter commented on CSV-69:
------------------------------------
I had a look at Bob's CsvParserTestUtil. He wrote a helper method for two dimensional String arrays using JUnit 3 features. How do we handle this? Do you plan to include Bob's CSVParserTestUtils? Then I can wait and rewrite my test afterwards.
> Eliminate CSVPrinterTest.equals(String[][], String[][]) by using Assert.assertArrayEquals
> -----------------------------------------------------------------------------------------
>
> Key: CSV-69
> URL: https://issues.apache.org/jira/browse/CSV-69
> Project: Commons CSV
> Issue Type: Test
> Reporter: Benedikt Ritter
> Attachments: CSV-69.patch
>
>
> CSVPrinterTest uses an equals method to compare two dimensional String arrays. Since the project has been updated to JUnit 4, Assert.assertArrayEquals() can be used instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CSV-69) Eliminate
CSVPrinterTest.equals(String[][], String[][]) by using
Assert.assertArrayEquals
Posted by "Sebb (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CSV-69?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb resolved CSV-69.
---------------------
Resolution: Fixed
> Eliminate CSVPrinterTest.equals(String[][], String[][]) by using Assert.assertArrayEquals
> -----------------------------------------------------------------------------------------
>
> Key: CSV-69
> URL: https://issues.apache.org/jira/browse/CSV-69
> Project: Commons CSV
> Issue Type: Test
> Reporter: Benedikt Ritter
> Attachments: CSV-69.patch
>
>
> CSVPrinterTest uses an equals method to compare two dimensional String arrays. Since the project has been updated to JUnit 4, Assert.assertArrayEquals() can be used instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CSV-69) Eliminate
CSVPrinterTest.equals(String[][], String[][]) by using
Assert.assertArrayEquals
Posted by "Emmanuel Bourg (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CSV-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231344#comment-13231344 ]
Emmanuel Bourg commented on CSV-69:
-----------------------------------
There is a similar proposal in the code attached to CSV-42. Bob Smith contributed a helper class for the tests, that might be worth merging your efforts.
> Eliminate CSVPrinterTest.equals(String[][], String[][]) by using Assert.assertArrayEquals
> -----------------------------------------------------------------------------------------
>
> Key: CSV-69
> URL: https://issues.apache.org/jira/browse/CSV-69
> Project: Commons CSV
> Issue Type: Test
> Reporter: Benedikt Ritter
> Attachments: CSV-69.patch
>
>
> CSVPrinterTest uses an equals method to compare two dimensional String arrays. Since the project has been updated to JUnit 4, Assert.assertArrayEquals() can be used instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CSV-69) Eliminate
CSVPrinterTest.equals(String[][], String[][]) by using
Assert.assertArrayEquals
Posted by "Benedikt Ritter (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CSV-69?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benedikt Ritter updated CSV-69:
-------------------------------
Attachment: CSV-69.patch
I've created a patch. Note that CSVParserTest uses CSVPrinterTest.assertArrayEquals(). assertArrayEquals seems to be misplaced in CSVPrinterTest. I guess it would be better create something like ArrayAsserts and move that method there. Please comment on this.
TIA
Benedikt
> Eliminate CSVPrinterTest.equals(String[][], String[][]) by using Assert.assertArrayEquals
> -----------------------------------------------------------------------------------------
>
> Key: CSV-69
> URL: https://issues.apache.org/jira/browse/CSV-69
> Project: Commons CSV
> Issue Type: Test
> Reporter: Benedikt Ritter
> Attachments: CSV-69.patch
>
>
> CSVPrinterTest uses an equals method to compare two dimensional String arrays. Since the project has been updated to JUnit 4, Assert.assertArrayEquals() can be used instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CSV-69) Eliminate
CSVPrinterTest.equals(String[][], String[][]) by using
Assert.assertArrayEquals
Posted by "Emmanuel Bourg (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CSV-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231611#comment-13231611 ]
Emmanuel Bourg commented on CSV-69:
-----------------------------------
I thought it would be worth adding his contribution, but if you have a better and more up to date approach to suggest, go for it.
> Eliminate CSVPrinterTest.equals(String[][], String[][]) by using Assert.assertArrayEquals
> -----------------------------------------------------------------------------------------
>
> Key: CSV-69
> URL: https://issues.apache.org/jira/browse/CSV-69
> Project: Commons CSV
> Issue Type: Test
> Reporter: Benedikt Ritter
> Attachments: CSV-69.patch
>
>
> CSVPrinterTest uses an equals method to compare two dimensional String arrays. Since the project has been updated to JUnit 4, Assert.assertArrayEquals() can be used instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira