You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@teaclave.apache.org by GitBox <gi...@apache.org> on 2020/04/04 12:21:29 UTC
[GitHub] [incubator-teaclave-sgx-sdk] sammyne opened a new pull request
#217: refactor(sgx_tunittest): remove the necessary 'std' import for
'should_panic' macro
sammyne opened a new pull request #217: refactor(sgx_tunittest): remove the necessary 'std' import for 'should_panic' macro
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/217
## Problem
The `should_panic!` macro in `sgx_tunittest` uses `std::panic`, which requires us the imports
`std::panic` every time we use `should_panic!`.
A demo project goes as [patch-sgx_tunittest](https://github.com/sammyne/patch-sgx_tunittest).
To verify, just comment out the patch section of Cargo.toml.
The project demonstrates the this inconvenience, and helps to support [this patch](https://github.com/sammyne/incubator-teaclave-sgx-sdk/commit/34a50a6307b2853d907b3a457cf9c961074f98e0#diff-b02276d3fdf8ec232bd27c1b90221758R109).
The patch mainly add the `std::` prefix to the `panic` function in use so as to avoid explicit
import of the `std::panic` every time.
Hope it helps~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave-sgx-sdk] dingelish commented on issue #217:
refactor(sgx_tunittest): remove the necessary 'std::panic' import for
'should_panic' macro
Posted by GitBox <gi...@apache.org>.
dingelish commented on issue #217: refactor(sgx_tunittest): remove the necessary 'std::panic' import for 'should_panic' macro
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/217#issuecomment-609939507
Thanks @sammyne
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave-sgx-sdk] dingelish merged pull request #217:
refactor(sgx_tunittest): remove the necessary 'std::panic' import for
'should_panic' macro
Posted by GitBox <gi...@apache.org>.
dingelish merged pull request #217: refactor(sgx_tunittest): remove the necessary 'std::panic' import for 'should_panic' macro
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/217
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org