You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shiro.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/29 16:16:20 UTC

[jira] [Commented] (SHIRO-577) Unable to set custom SessionValidationScheduler

    [ https://issues.apache.org/jira/browse/SHIRO-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399597#comment-15399597 ] 

ASF GitHub Bot commented on SHIRO-577:
--------------------------------------

GitHub user bdemers opened a pull request:

    https://github.com/apache/shiro/pull/34

    SHIRO-577 Fixes bug allow enabling of SessionValidationScheduler when set via setSessionValidationScheduler

    If a SessionValidationScheduler was set via sessionManager.setSessionValidationScheduler, instead of using the
    default creation of the object in enableSessionValidation, the SessionValidationScheduler would not be enabled.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bdemers/shiro SHIRO-577

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/shiro/pull/34.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #34
    
----
commit c7e0f854caa6e0ab7d9f0508fb580a59dce49436
Author: Brian Demers <bd...@apache.org>
Date:   2016-07-29T16:13:46Z

    SHIRO-577 Fixes bug allow enabling of SessionValidationScheduler when set via setSessionValidationScheduler
    
    If a SessionValidationScheduler was set via sessionManager.setSessionValidationScheduler, instead of using the
    default creation of the object in enableSessionValidation, the SessionValidationScheduler would not be enabled.

----


> Unable to set custom SessionValidationScheduler
> -----------------------------------------------
>
>                 Key: SHIRO-577
>                 URL: https://issues.apache.org/jira/browse/SHIRO-577
>             Project: Shiro
>          Issue Type: Bug
>          Components: Session Management
>    Affects Versions: 1.2.5, 1.3.0, 1.26
>            Reporter: Brian Demers
>              Labels: regresion
>
> This was introduced by SHIRO-443, while making initialization of the sessionValidationScheulder thread safe.
> Reported by user on mailing list:
> http://shiro-user.582556.n2.nabble.com/Shiro-443-prevents-custom-Session-Validation-Scheduler-td7581185.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)