[GitHub] flink pull request: [streaming] Fast calculation of medians of win...

[ggevay <gi...@git.apache.org>]

Github user ggevay commented on the pull request:

    https://github.com/apache/flink/pull/684#issuecomment-110739389
  
    I did the Scala part, and added a Jira (FLINK-2145).
    As for the placement:
    @StephanEwen:
    > I think we should put the code into a streaming operator library. The streaming core is undergoing heavy changes, the windowing may be reworked in the near future, and there are plans to use managed memory for window buffer contents.
    
    I am not sure how putting this into a separate library helps a future refactoring of windowing. Most of the median code is inside the new PreReducers, so it is probably already separated from the rest of the code as well as it can be.
    (Also, if you are worried about bloating the API for the users, I don't think median would hurt in that respect either: the function of a method named "median" should be pretty clear to the users.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---