You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by no...@apache.org on 2010/10/09 15:10:22 UTC

svn commit: r1006153 - /james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageInputStreamSource.java

Author: norman
Date: Sat Oct  9 13:10:22 2010
New Revision: 1006153

URL: http://svn.apache.org/viewvc?rev=1006153&view=rev
Log:
Cleanup

Modified:
    james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageInputStreamSource.java

Modified: james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageInputStreamSource.java
URL: http://svn.apache.org/viewvc/james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageInputStreamSource.java?rev=1006153&r1=1006152&r2=1006153&view=diff
==============================================================================
--- james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageInputStreamSource.java (original)
+++ james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageInputStreamSource.java Sat Oct  9 13:10:22 2010
@@ -24,6 +24,8 @@ package org.apache.james.core;
 import javax.mail.MessagingException;
 import javax.mail.util.SharedFileInputStream;
 
+import org.apache.commons.io.FileUtils;
+import org.apache.commons.io.IOUtils;
 import org.apache.james.lifecycle.Disposable;
 
 import java.io.BufferedOutputStream;
@@ -182,27 +184,12 @@ public class MimeMessageInputStreamSourc
     public void dispose() {
         // explicit close all streams
         for (int i = 0; i < streams.size(); i++) {
-            try {
-                streams.get(i).close();
-            } catch (IOException e) {
-                // ignore on dispose
-            }
-        }
-        if (out != null) {
-            try {
-                out.close();
-            } catch (IOException e) {
-                // TODO Auto-generated catch block
-                e.printStackTrace();
-            }
-        }
-        try {
-            if (file != null && file.exists()) {
-                file.delete();
-            }
-        } catch (Exception e) {
-            //ignore
+            IOUtils.closeQuietly(streams.get(i));
         }
+        IOUtils.closeQuietly(out);
+        out = null;
+        
+        FileUtils.deleteQuietly(file);
         file = null;
     }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org