[jira] [Commented] (MSITE-873) Mark SiteMojo and SiteJarMojo thread-safe

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MSITE-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717282#comment-17717282 ] 

ASF GitHub Bot commented on MSITE-873:
--------------------------------------

michael-o opened a new pull request, #149:
URL: https://github.com/apache/maven-site-plugin/pull/149

   Both mojos operate on individual modules and do not share any state.
   
   This closes #149
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSITE) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without 
          pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[MSITE-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `MSITE-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the 
          commit message.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will 
          be performed on your pull request automatically.
    - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   




> Mark SiteMojo and SiteJarMojo thread-safe
> -----------------------------------------
>
>                 Key: MSITE-873
>                 URL: https://issues.apache.org/jira/browse/MSITE-873
>             Project: Maven Site Plugin
>          Issue Type: Improvement
>            Reporter: PatPatPat123
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 4.0.0-M8
>
>
> Hello Maven Site Plugin Team,
> This is my first post here, apologies in advanced if this post is not respecting conventions.
> There is currently an issue with the version 3.9.1 of maven-site-plugin when running in multithread environment.
> {code:xml}<plugin>
>   <groupId>org.apache.maven.plugins</groupId>
>   <artifactId>maven-site-plugin</artifactId>
>   <version>3.9.1</version>
> </plugin>{code}
>  
> The setup is simple and reproducible 100%.
> Nowadays, maven multimode is very popular, especially among micro services pattern.
> For instance, within one maven project, possibility to have many multi module micro service.
>  
> And often it makes sense to run maven commands on them in parallel.
>  
> Unfortunately, the current maven multi module will yield this issue:
>  {noformat}
>  [INFO] --------------------------------[ pom ]---------------------------------
>  [WARNING] *****************************************************************
>  [WARNING] * Your build is requesting parallel execution, but project      *
>  [WARNING] * contains the following plugin(s) that have goals not marked   *
>  [WARNING] * as @threadSafe to support parallel building.                  *
>  [WARNING] * While this /may/ work fine, please look for plugin updates    *
>  * While this /may/ work fine, please look for plugin updates    *
>  * and/or request plugins be made thread-safe.                   *
>  * If reporting an issue, report it against the plugin in        *
>  * question, not against maven-core                              *
>  *****************************************************************
>  The following plugins are not marked @threadSafe in X:
>  org.apache.maven.plugins:maven-site-plugin:3.9.1
>  Enable debug to see more precisely which goals are not marked @threadSafe.
>  *****************************************************************
>  {noformat}
>   
> Allowing this plugin to fully be compatible with parallel maven execution would be a great plus of this plugin.
>  
> Also, maybe the fix is as simple as 
> {code:java}@Mojo(name = "generate", requiresProject = true, defaultPhase = LifecyclePhase.INTEGRATION_TEST, requiresDependencyResolution = ResolutionScope.TEST, threadSafe = true){code}
> Nonetheless, wanted to say thanks for this great project, and hopefully to have this issue fixed.
> Good day!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)