You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2020/07/09 07:51:46 UTC
[GitHub] [groovy] mardukbp opened a new pull request #1305: Updated the path to assets/img in groovy-console.adoc
mardukbp opened a new pull request #1305:
URL: https://github.com/apache/groovy/pull/1305
assets is now in the spec directory, one directory above.
Now the images are shown in the documentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] asfgit closed pull request #1305: Updated the path to assets/img in groovy-console.adoc
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1305:
URL: https://github.com/apache/groovy/pull/1305
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert edited a comment on pull request #1305: Updated the path to assets/img in groovy-console.adoc
Posted by GitBox <gi...@apache.org>.
paulk-asert edited a comment on pull request #1305:
URL: https://github.com/apache/groovy/pull/1305#issuecomment-656025857
Thanks for looking at this. We do need to fix it. Unfortunately, there would be more to do than just your suggestion. While it fixes the images in the IDE, it then breaks the generated content (which is currently correct). Looking at the history:
https://github.com/apache/groovy/commit/bdaef2a1539d3b3d0a9a5fa549ddd7421673797f
It looks like we made the move to improve consistency. Perhaps we should have moved the other projects instead.
Let me know if you want to look into this further or otherwise I might just revert the above commit and we can then move other subprojects over to be similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1305: Updated the path to assets/img in groovy-console.adoc
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on pull request #1305:
URL: https://github.com/apache/groovy/pull/1305#issuecomment-656025857
Thanks for looking at this. We do need to fix it. Unfortunately, there would be more to do than just your suggestion. While it fixes the images in the IDE, it then breaks the generated content (which is currently correct). Looking at the history:
https://github.com/apache/groovy/commit/bdaef2a1539d3b3d0a9a5fa549ddd7421673797f
It looks like we made the move to improve consistency. Perhaps we should have moved the other projects instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] mardukbp commented on pull request #1305: Updated the path to assets/img in groovy-console.adoc
Posted by GitBox <gi...@apache.org>.
mardukbp commented on pull request #1305:
URL: https://github.com/apache/groovy/pull/1305#issuecomment-656039516
What matters is that the images are shown in the documentation.
In particular, I think that visualizing the results using Swing is a
great feature of the Groovy Console and the image is key to make
people interested in using it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1305: Updated the path to assets/img in groovy-console.adoc
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on pull request #1305:
URL: https://github.com/apache/groovy/pull/1305#issuecomment-656049356
The images do currently appear in the documentation:
http://groovy-lang.org/groovyconsole.html
And also if you have the source checked out from github and then run `gradlew :groovy-console:asciidoc` and look in the generated directory, e.g. `subprojects/groovy-console/target/asciidoc/html5/groovy-console.html` you will see that it is correct.
Where it is currently not showing up correctly is browsing the source online, e.g.
https://github.com/apache/groovy/blob/master/subprojects/groovy-console/src/spec/doc/groovy-console.adoc
or browsing the source from the checked out github repo from within an IDE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1305: Updated the path to assets/img in groovy-console.adoc
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on pull request #1305:
URL: https://github.com/apache/groovy/pull/1305#issuecomment-656132955
I just moved everything, as per [b388a251aee](https://github.com/apache/groovy/commit/b388a251aee3e03b9bd3d5ed5f2fcbe6158bc85d), to hopefully correct what you observed. Let me know if you spot anything out of place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] mardukbp commented on pull request #1305: Updated the path to assets/img in groovy-console.adoc
Posted by GitBox <gi...@apache.org>.
mardukbp commented on pull request #1305:
URL: https://github.com/apache/groovy/pull/1305#issuecomment-656102589
Thanks for the references. I guess that if the paths in the AsciiDoc files work, then while building the documentation either the files are moved or the paths are modified. So either the AsciiDoc files or the build script(s) have to be modified. Am I missing something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert edited a comment on pull request #1305: Updated the path to assets/img in groovy-console.adoc
Posted by GitBox <gi...@apache.org>.
paulk-asert edited a comment on pull request #1305:
URL: https://github.com/apache/groovy/pull/1305#issuecomment-656025857
Thanks for looking at this. We do need to fix it. Unfortunately, there would be more to do than just your suggestion. While it fixes the images in the IDE, it then breaks the generated content (which is currently correct). Looking at the history:
https://github.com/apache/groovy/commit/bdaef2a1539d3b3d0a9a5fa549ddd7421673797f
It looks like we made the move to improve consistency. Perhaps we should have moved the other projects instead.
Let me know if you want to look into this further or otherwise I might just revert the above commit from 2016 and we can then move other subprojects over to be similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org