You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Daan Hoogland <da...@gmail.com> on 2019/02/08 15:58:55 UTC
project does not build anymore on macos
LS,
Due to changes in LibvirtResource recently merged, the project will err out
during unit tests on macos. This happens because of
c496c84c6c727a84862cbbe2d870ff57939488b4 that changes the initialisation of
memstats, requiring /proc/meminfo to exist (during unit tests). The
requirement makes perfect sense in production, so a simple roll-back seems
not the way to go. @Wido den Hollander <wi...@widodh.nl>, you created the
change, can you think with me what to do here?
/cc @Rafael Weingartner <ra...@gmail.com> @Gabriel Beims
Bräscher <ga...@gmail.com> @Rohit Yadav <ro...@gmail.com>
--
Daan
Re: project does not build anymore on macos
Posted by Gabriel Beims Bräscher <ga...@gmail.com>.
I am addressing a fix for this issue in PR
https://github.com/apache/cloudstack/pull/3173.
Em sex, 8 de fev de 2019 às 14:52, Daan Hoogland <da...@gmail.com>
escreveu:
> thanks guys
>
> On Fri, Feb 8, 2019 at 5:27 PM Gabriel Beims Bräscher <
> gabrascher@gmail.com>
> wrote:
>
> > It looks like we can fix that by applying a "Mock" on the test; I will
> open
> > a PR addressing it soon and ping you guys when having it ready for
> review.
> >
> > Em sex, 8 de fev de 2019 às 14:02, Simon Weller <sw...@ena.com>
> > escreveu:
> >
> > > I know Nathan and Gabriel discussed this a couple of weeks ago, as
> Nathan
> > > does his dev builds on a mac. I'm not sure if a patch idea came out of
> > that
> > > discussion or not.
> > >
> > > -Si
> > >
> > >
> > > ------------------------------
> > > *From:* Daan Hoogland <da...@gmail.com>
> > > *Sent:* Friday, February 8, 2019 9:58 AM
> > > *To:* dev; Wido den Hollander
> > > *Cc:* Rafael Weingartner; Gabriel Beims Bräscher; Rohit Yadav
> > > *Subject:* project does not build anymore on macos
> > >
> > > LS,
> > >
> > > Due to changes in LibvirtResource recently merged, the project will err
> > out
> > > during unit tests on macos. This happens because of
> > > c496c84c6c727a84862cbbe2d870ff57939488b4 that changes the
> initialisation
> > of
> > > memstats, requiring /proc/meminfo to exist (during unit tests). The
> > > requirement makes perfect sense in production, so a simple roll-back
> > seems
> > > not the way to go. @Wido den Hollander <wi...@widodh.nl>, you created
> the
> > > change, can you think with me what to do here?
> > > /cc @Rafael Weingartner <ra...@gmail.com> @Gabriel Beims
> > > Bräscher <ga...@gmail.com> @Rohit Yadav <ro...@gmail.com>
> > >
> > > --
> > > Daan
> > >
> >
>
>
> --
> Daan
>
Re: project does not build anymore on macos
Posted by Daan Hoogland <da...@gmail.com>.
thanks guys
On Fri, Feb 8, 2019 at 5:27 PM Gabriel Beims Bräscher <ga...@gmail.com>
wrote:
> It looks like we can fix that by applying a "Mock" on the test; I will open
> a PR addressing it soon and ping you guys when having it ready for review.
>
> Em sex, 8 de fev de 2019 às 14:02, Simon Weller <sw...@ena.com>
> escreveu:
>
> > I know Nathan and Gabriel discussed this a couple of weeks ago, as Nathan
> > does his dev builds on a mac. I'm not sure if a patch idea came out of
> that
> > discussion or not.
> >
> > -Si
> >
> >
> > ------------------------------
> > *From:* Daan Hoogland <da...@gmail.com>
> > *Sent:* Friday, February 8, 2019 9:58 AM
> > *To:* dev; Wido den Hollander
> > *Cc:* Rafael Weingartner; Gabriel Beims Bräscher; Rohit Yadav
> > *Subject:* project does not build anymore on macos
> >
> > LS,
> >
> > Due to changes in LibvirtResource recently merged, the project will err
> out
> > during unit tests on macos. This happens because of
> > c496c84c6c727a84862cbbe2d870ff57939488b4 that changes the initialisation
> of
> > memstats, requiring /proc/meminfo to exist (during unit tests). The
> > requirement makes perfect sense in production, so a simple roll-back
> seems
> > not the way to go. @Wido den Hollander <wi...@widodh.nl>, you created the
> > change, can you think with me what to do here?
> > /cc @Rafael Weingartner <ra...@gmail.com> @Gabriel Beims
> > Bräscher <ga...@gmail.com> @Rohit Yadav <ro...@gmail.com>
> >
> > --
> > Daan
> >
>
--
Daan
Re: project does not build anymore on macos
Posted by Gabriel Beims Bräscher <ga...@gmail.com>.
It looks like we can fix that by applying a "Mock" on the test; I will open
a PR addressing it soon and ping you guys when having it ready for review.
Em sex, 8 de fev de 2019 às 14:02, Simon Weller <sw...@ena.com> escreveu:
> I know Nathan and Gabriel discussed this a couple of weeks ago, as Nathan
> does his dev builds on a mac. I'm not sure if a patch idea came out of that
> discussion or not.
>
> -Si
>
>
> ------------------------------
> *From:* Daan Hoogland <da...@gmail.com>
> *Sent:* Friday, February 8, 2019 9:58 AM
> *To:* dev; Wido den Hollander
> *Cc:* Rafael Weingartner; Gabriel Beims Bräscher; Rohit Yadav
> *Subject:* project does not build anymore on macos
>
> LS,
>
> Due to changes in LibvirtResource recently merged, the project will err out
> during unit tests on macos. This happens because of
> c496c84c6c727a84862cbbe2d870ff57939488b4 that changes the initialisation of
> memstats, requiring /proc/meminfo to exist (during unit tests). The
> requirement makes perfect sense in production, so a simple roll-back seems
> not the way to go. @Wido den Hollander <wi...@widodh.nl>, you created the
> change, can you think with me what to do here?
> /cc @Rafael Weingartner <ra...@gmail.com> @Gabriel Beims
> Bräscher <ga...@gmail.com> @Rohit Yadav <ro...@gmail.com>
>
> --
> Daan
>
Re: project does not build anymore on macos
Posted by Simon Weller <sw...@ena.com.INVALID>.
I know Nathan and Gabriel discussed this a couple of weeks ago, as Nathan does his dev builds on a mac. I'm not sure if a patch idea came out of that discussion or not.
-Si
________________________________
From: Daan Hoogland <da...@gmail.com>
Sent: Friday, February 8, 2019 9:58 AM
To: dev; Wido den Hollander
Cc: Rafael Weingartner; Gabriel Beims Bräscher; Rohit Yadav
Subject: project does not build anymore on macos
LS,
Due to changes in LibvirtResource recently merged, the project will err out
during unit tests on macos. This happens because of
c496c84c6c727a84862cbbe2d870ff57939488b4 that changes the initialisation of
memstats, requiring /proc/meminfo to exist (during unit tests). The
requirement makes perfect sense in production, so a simple roll-back seems
not the way to go. @Wido den Hollander <wi...@widodh.nl>, you created the
change, can you think with me what to do here?
/cc @Rafael Weingartner <ra...@gmail.com> @Gabriel Beims
Bräscher <ga...@gmail.com> @Rohit Yadav <ro...@gmail.com>
--
Daan