You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/13 06:25:30 UTC

[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #1040: Support Error highlighting for plugin's code mirror

juzhiyuan opened a new issue #1040:
URL: https://github.com/apache/apisix-dashboard/issues/1040


   # Feature request
   
   ## Please describe your feature
   
   Currently, when we use plugin's CodeMirror, one error message will pop up when we input an invalid JSON data, it would be more clear to have the Error Line highlighting support for CodeMirror.
   
   Related issue: https://github.com/apache/apisix-dashboard/issues/815


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1040: Support Error highlighting for plugin's code mirror

Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #1040:
URL: https://github.com/apache/apisix-dashboard/issues/1040


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] qian0817 commented on issue #1040: Support Error highlighting for plugin's code mirror

Posted by GitBox <gi...@apache.org>.
qian0817 commented on issue #1040:
URL: https://github.com/apache/apisix-dashboard/issues/1040#issuecomment-824126221


   @juzhiyuan Can I use the [monaco editor](https://microsoft.github.io/monaco-editor/) instead of codemirror to achieve this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1040: Support Error highlighting for plugin's code mirror

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1040:
URL: https://github.com/apache/apisix-dashboard/issues/1040#issuecomment-824162470


   Sure! that's what I want to do!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on issue #1040: Support Error highlighting for plugin's code mirror

Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1040:
URL: https://github.com/apache/apisix-dashboard/issues/1040#issuecomment-771450642


   not urgent


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on issue #1040: Support Error highlighting for plugin's code mirror

Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1040:
URL: https://github.com/apache/apisix-dashboard/issues/1040#issuecomment-771450642


   not urgent


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] LiteSun commented on issue #1040: Support Error highlighting for plugin's code mirror

Posted by GitBox <gi...@apache.org>.
LiteSun commented on issue #1040:
URL: https://github.com/apache/apisix-dashboard/issues/1040#issuecomment-824441044


   Good to go.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1040: Support Error highlighting for plugin's code mirror

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1040:
URL: https://github.com/apache/apisix-dashboard/issues/1040#issuecomment-824162834


   But you may face some issues from E2E test, you could ask for @guoqqqi @LiteSun to help you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org