You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Eric Norman (Jira)" <ji...@apache.org> on 2023/06/12 16:36:00 UTC
[jira] [Comment Edited] (SLING-11906) Migrate to slf4j 2.x
[ https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731684#comment-17731684 ]
Eric Norman edited comment on SLING-11906 at 6/12/23 4:35 PM:
--------------------------------------------------------------
[~rombert] Yes, that is what I was implying in the last sentence of the description. Specifically slf4j-api 2.0.7 has the changes from [https://github.com/qos-ch/slf4j/commit/b363bb31ed08d3ad9761ccdca5e51bb2327c3287] that should make that possible for slf4j-api 1.x consumers to still satisfy their requirements.
Unfortunately, after some quick experimenting, it looks like swapping out the slf4j-api with the 2.0.7 version is likely the easy part. Updating to the latest version of the embedded logback library appears to have incompatible changes (logback.version 1.2.10 vs 1.4.7) that impact what was done in the o.a.sling.commons.log bundle. I'm not familiar with the code in the o.a.sling.commons.log bundle so unless someone else wants to volunteer to do the refactoring then I would need to try to find some time to understand, unwind and fix what that code is doing. After my first attempt at refactoring I can get it to compile, but there are many integration tests that fail.
was (Author: enorman):
[~rombert] Yes, that is what I was implying in the last sentence of the description. Specifically slf4j-api 2.0.7 has the changes from [https://github.com/qos-ch/slf4j/commit/b363bb31ed08d3ad9761ccdca5e51bb2327c3287] that should make that possible for slf4j-api 1.x consumers to still satisfy their requirements.
Unfortunately, after some quick experimenting, it looks like swapping out the slf4j-api with the 2.0.7 version is like the easy part. Updating to the latest version of the embedded logback library appears to have incompatible changes (logback.version 1.2.10 vs 1.4.7) that impact what was done in the o.a.sling.commons.log bundle. I'm not familiar with the code in the o.a.sling.commons.log bundle so unless someone else wants to volunteer to do the refactoring then I would need to try to find some time to understand, unwind and fix what that code is doing. After my first attempt at refactoring I can get it to compile, but there are many integration tests that fail.
> Migrate to slf4j 2.x
> --------------------
>
> Key: SLING-11906
> URL: https://issues.apache.org/jira/browse/SLING-11906
> Project: Sling
> Issue Type: Improvement
> Reporter: Eric Norman
> Priority: Major
> Fix For: Commons Log 6.0.0
>
>
> Increasingly more libraries have been migrating to slf4j 2.x (for example logback 1.3+, tika 2.5+ and jetty 10+)
> To be compatible with those, the sling commons log bundle should migrate to slf4j v2.0.7 (and logback v1.4.7)
> It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported packages, so it should hopefully be compatible with existing bundles that are importing the 1.x version of the slf4j packages.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)