[GitHub] [zookeeper] enixon commented on a change in pull request #851: ZOOKEEPER-3311: Allow a delay to the transaction log flush

[GitBox <gi...@apache.org>]

enixon commented on a change in pull request #851: ZOOKEEPER-3311: Allow a delay to the transaction log flush
URL: https://github.com/apache/zookeeper/pull/851#discussion_r265747461
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
 ##########
 @@ -145,6 +145,10 @@
     private ZooKeeperServerShutdownHandler zkShutdownHandler;
     private volatile int createSessionTrackerServerId = 1;
 
+    private static volatile long flushDelay = Long.getLong("zookeeper.flushDelay", 0);
 
 Review comment:
   Them being static is in support of the values being alterable via jmx. Without this, the admin is stuck resetting the values every time a new ZooKeeperServer is instantiated. 
   
   In my mind, it's a question of how to support this style of setting: via static variables close to the code that uses them or via non-static mutable config (such as QuorumPeerConfig).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services