You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/06/23 18:41:16 UTC
[jira] [Commented] (TS-4449) header_rewrite: Improve TSDebug()
statements
[ https://issues.apache.org/jira/browse/TS-4449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346945#comment-15346945 ]
ASF GitHub Bot commented on TS-4449:
------------------------------------
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/735
TS-4449 header_rewrite: Better errors and debug output
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver TS-4449
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/735.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #735
----
commit aa67ba46f6e6bfe0193128eae12f8ee2c954770b
Author: Leif Hedstrom <zw...@apache.org>
Date: 2016-05-17T18:20:32Z
TS-4449 Cleanup of coding style
commit 857278154f62043bbecb1fd59b8c898a823aa65f
Author: Leif Hedstrom <zw...@apache.org>
Date: 2016-05-17T19:12:19Z
TS-4449 Better errors and debug output
This does a few things:
1. Better error reports when parsing a config file
2. Better diagnostics when debugging expressions
I also added an example to the docs, for a common use case that
turns out to be non-obvious.
----
> header_rewrite: Improve TSDebug() statements
> --------------------------------------------
>
> Key: TS-4449
> URL: https://issues.apache.org/jira/browse/TS-4449
> Project: Traffic Server
> Issue Type: Improvement
> Components: Plugins
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>
> Right now, it can be difficult at times to understand why header_rewrite isn't behaving as you'd expect. There are a number of places where we can improve TSDebug().
> Also, I'm going to do a code cleanup here, to make the code more inline with our current best practices (e.g. use if () { } consistently).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)