You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/01 01:15:09 UTC
[GitHub] [spark] venkata91 commented on a change in pull request #34122: [SPARK-34826][SHUFFLE] Adaptively fetch shuffle mergers for push based shuffle
venkata91 commented on a change in pull request #34122:
URL: https://github.com/apache/spark/pull/34122#discussion_r796195454
##########
File path: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
##########
@@ -3926,7 +3925,7 @@ class DAGSchedulerSuite extends SparkFunSuite with TempLocalSparkContext with Ti
val finalizeTask1 = shuffleStage1.shuffleDep.getFinalizeTask.get
.asInstanceOf[DummyScheduledFuture]
assert(finalizeTask1.delay == 10 && finalizeTask1.registerMergeResults)
- assert(shuffleStage1.shuffleDep.shuffleMergeFinalized)
+ assert(shuffleStage1.shuffleDep.isShuffleMergeFinalizedMarked)
Review comment:
Based on the above [comment](https://github.com/apache/spark/pull/34122#discussion_r796060753), not making the change
##########
File path: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
##########
@@ -4051,8 +4050,8 @@ class DAGSchedulerSuite extends SparkFunSuite with TempLocalSparkContext with Ti
runEvent(StageCancelled(0, Option("Explicit cancel check")))
scheduler.handleShuffleMergeFinalized(shuffleStage1, shuffleStage1.shuffleDep.shuffleMergeId)
- assert(shuffleStage1.shuffleDep.shuffleMergeEnabled)
- assert(!shuffleStage1.shuffleDep.shuffleMergeFinalized)
+ assert(shuffleStage1.shuffleDep.mergerLocs.nonEmpty)
+ assert(!shuffleStage1.shuffleDep.isShuffleMergeFinalizedMarked)
Review comment:
Based on the above [comment](https://github.com/apache/spark/pull/34122#discussion_r796060753), not making the change
##########
File path: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
##########
@@ -4082,7 +4081,7 @@ class DAGSchedulerSuite extends SparkFunSuite with TempLocalSparkContext with Ti
assert(shuffleIndeterminateStage.isIndeterminate)
scheduler.handleShuffleMergeFinalized(shuffleIndeterminateStage, 2)
assert(shuffleIndeterminateStage.shuffleDep.shuffleMergeEnabled)
- assert(!shuffleIndeterminateStage.shuffleDep.shuffleMergeFinalized)
+ assert(!shuffleIndeterminateStage.shuffleDep.isShuffleMergeFinalizedMarked)
}
Review comment:
Same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org