You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/10/11 10:47:26 UTC
[GitHub] [netbeans] dbalek opened a new pull request, #4769: Code completion after yield in switch expressions fixed.
dbalek opened a new pull request, #4769:
URL: https://github.com/apache/netbeans/pull/4769
Fixing code completion after typing yield in switch expressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4769: Code completion after yield in switch expressions fixed.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4769:
URL: https://github.com/apache/netbeans/pull/4769#issuecomment-1274710847
@mbien `refs/pull/*/merge` is meant to be the results of a potential merge at the time the action runs.
Sorry for the OT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4769: Code completion after yield in switch expressions fixed.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4769:
URL: https://github.com/apache/netbeans/pull/4769#issuecomment-1274621510
please label PRs accordingly. This PR is not running the right tests.
https://lists.apache.org/thread/3gyc3xvxjjh8osh5rd6k81lshtno0j0z
the description mentions what tests are added for each label
https://github.com/apache/netbeans/labels?q=%5Bci%5D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4769: Code completion after yield in switch expressions fixed.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4769:
URL: https://github.com/apache/netbeans/pull/4769#issuecomment-1274719973
ok I am starting a fresh workflow without a sync
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4769: Code completion after yield in switch expressions fixed.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4769:
URL: https://github.com/apache/netbeans/pull/4769#issuecomment-1274698654
> @mbien should just be able to retrigger without resync - actions build is of a merge of the PR with master.
but this would fail here too, since master fails without Jan's fix. If this is based on old master it would test without the PR in question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] dbalek merged pull request #4769: Code completion after yield in switch expressions fixed.
Posted by GitBox <gi...@apache.org>.
dbalek merged PR #4769:
URL: https://github.com/apache/netbeans/pull/4769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4769: Code completion after yield in switch expressions fixed.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4769:
URL: https://github.com/apache/netbeans/pull/4769#issuecomment-1274937128
testCaseLabels 1,2,3 still failing, likely caused by #4746:
```
org.netbeans.junit.AssertionFileFailedError: Difference between /home/runner/work/netbeans/netbeans/java/java.completion/build/test/unit/work/o.n.m.j.c.J/cl/testCaseLabels_1.out and /home/runner/work/netbeans/netbeans/java/java.completion/build/test/unit/data/goldenfiles/org/netbeans/modules/java/completion/JavaCompletionTaskTest/1.8/AutoCompletion_CaseLabels_PatternMatchingSwitch_1.pass
diff: /home/runner/work/netbeans/netbeans/java/java.completion/build/test/unit/work/o.n.m.j.c.J/cl/testCaseLabels_1.diff
at org.netbeans.junit.NbTestCase.assertFile(NbTestCase.java:742)
at org.netbeans.junit.NbTestCase.assertFile(NbTestCase.java:792)
at org.netbeans.modules.java.completion.CompletionTestBase.performTest(CompletionTestBase.java:110)
at org.netbeans.modules.java.completion.JavaCompletionTask117FeaturesTest.testCaseLabels_1(JavaCompletionTask117FeaturesTest.java:55)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at org.netbeans.junit.NbTestCase.access$200(NbTestCase.java:77)
at org.netbeans.junit.NbTestCase$2.doSomething(NbTestCase.java:476)
at org.netbeans.junit.NbTestCase$1Guard.run(NbTestCase.java:402)
at java.base/java.lang.Thread.run(Thread.java:829)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4769: Code completion after yield in switch expressions fixed.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4769:
URL: https://github.com/apache/netbeans/pull/4769#issuecomment-1274683037
this PR is fixing the three failing testcases in `java/java.completion` `org.netbeans.modules.java.completion.JavaCompletionTask117FeaturesTest` under JDK 11+?
if yes, please sync again from master so that it contains the fix of #4756. After that, everything should be green again hopefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4769: Code completion after yield in switch expressions fixed.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4769:
URL: https://github.com/apache/netbeans/pull/4769#issuecomment-1274694520
@mbien should just be able to retrigger without resync - actions build is of a merge of the PR with master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4769: Code completion after yield in switch expressions fixed.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4769:
URL: https://github.com/apache/netbeans/pull/4769#issuecomment-1274722144
@mbien thanks - it seems a good test that this scenario works! Will hide the OT comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists