[camel] branch master updated: CAMEL-12148: Reworked FileIdempontentRepository so LRUCache is only act as quick lookup. And in case of 1st-level miss the file store is checked. File store also writes the entries in the same order they are added.

[da...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

davsclaus pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git


The following commit(s) were added to refs/heads/master by this push:
     new 8b42f4e  CAMEL-12148: Reworked FileIdempontentRepository so LRUCache is only act as quick lookup. And in case of 1st-level miss the file store is checked. File store also writes the entries in the same order they are added.
8b42f4e is described below

commit 8b42f4ec031755f0c507dcbf8538b5c10adc59e4
Author: Claus Ibsen <cl...@gmail.com>
AuthorDate: Wed Jan 17 09:19:32 2018 +0100

    CAMEL-12148: Reworked FileIdempontentRepository so LRUCache is only act as quick lookup. And in case of 1st-level miss the file store is checked. File store also writes the entries in the same order they are added.
---
 .../camel/processor/idempotent/FileIdempotentRepository.java  | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/camel-core/src/main/java/org/apache/camel/processor/idempotent/FileIdempotentRepository.java b/camel-core/src/main/java/org/apache/camel/processor/idempotent/FileIdempotentRepository.java
index 339838b..e441977 100644
--- a/camel-core/src/main/java/org/apache/camel/processor/idempotent/FileIdempotentRepository.java
+++ b/camel-core/src/main/java/org/apache/camel/processor/idempotent/FileIdempotentRepository.java
@@ -45,9 +45,9 @@ import org.slf4j.LoggerFactory;
  * frequently used keys. When {@link #add(String)} or {@link #contains(String)} methods are being used
  * then in case of 1st-level cache miss, the underlying file is scanned which may cost additional performance.
  * So try to find the right balance of the size of the 1st-level cache, the default size is 1000.
- * The file store has a maximum capacity of 32mb by default. If the file store grows bigger, then
- * the {@link #getDropOldestFileStore()} number of entries from the file store is dropped to reduce
- * the file store and make room for newer entries.
+ * The file store has a maximum capacity of 32mb by default (you can turn this off and have unlimited size).
+ * If the file store grows bigger than the maximum capacity, then the {@link #getDropOldestFileStore()} (is default 1000)
+ * number of entries from the file store is dropped to reduce the file store and make room for newer entries.
  *
  * @version 
  */
@@ -140,8 +140,8 @@ public class FileIdempotentRepository extends ServiceSupport implements Idempote
                 // its a new key so append to file store
                 appendToStore(key);
 
-                // check if we hit maximum capacity and report a warning about this
-                if (fileStore.length() > maxFileStoreSize) {
+                // check if we hit maximum capacity (if enabled) and report a warning about this
+                if (maxFileStoreSize > 0 && fileStore.length() > maxFileStoreSize) {
                     LOG.warn("Maximum capacity of file store: {} hit at {} bytes. Dropping {} oldest entries from the file store", fileStore, maxFileStoreSize, dropOldestFileStore);
                     trunkStore();
                 }
@@ -215,6 +215,7 @@ public class FileIdempotentRepository extends ServiceSupport implements Idempote
 
     /**
      * Sets the maximum file size for the file store in bytes.
+     * You can set the value to 0 or negative to turn this off, and have unlimited file store size.
      * <p/>
      * The default is 32mb.
      */

-- 
To stop receiving notification emails like this one, please contact
['"commits@camel.apache.org" <co...@camel.apache.org>'].