[GitHub] [hbase] virajjasani commented on a change in pull request #1074: HBASE-23350 Make compaction files cacheonWrite configurable based on threshold

[GitBox <gi...@apache.org>]

virajjasani commented on a change in pull request #1074: HBASE-23350 Make compaction files cacheonWrite configurable based on threshold
URL: https://github.com/apache/hbase/pull/1074#discussion_r368721998
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
 ##########
 @@ -87,6 +87,15 @@
   public static final String CACHE_COMPACTED_BLOCKS_ON_WRITE_KEY =
       "hbase.rs.cachecompactedblocksonwrite";
 
+  /**
+   * Configuration key to determine total size in bytes of compacted files beyond which we do not cache blocks on compaction
+   */
+  public static final String CACHE_COMPACTED_BLOCKS_ON_WRITE_THRESHOLD_KEY =
+      "hbase.rs.cachecompactedblocksonwritethreshold";
+
+  /**
+   * Configuration key to determine threshold beyond which cache on compaction should not work
 
 Review comment:
   Agree, I believe this can be removed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services