You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "xuzifu666 (via GitHub)" <gi...@apache.org> on 2023/12/12 06:18:34 UTC
[PR] [HUDI-7224] HoodieSparkSqlWriter metasync success or not show details messages log [hudi]
xuzifu666 opened a new pull request, #10314:
URL: https://github.com/apache/hudi/pull/10314
### Change Logs
HoodieSparkSqlWriter metasync success or not show details messages log to help user to confirm error in sparksql writing process
### Impact
none
### Risk level (write none, low medium or high below)
none
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7224] HoodieSparkSqlWriter metasync success or not show details messages log [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10314:
URL: https://github.com/apache/hudi/pull/10314#issuecomment-1851635963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88b9f8d9518f5afd376479ba9c87a8dd30170ffc",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21467",
"triggerID" : "88b9f8d9518f5afd376479ba9c87a8dd30170ffc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88b9f8d9518f5afd376479ba9c87a8dd30170ffc Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21467)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7224] HoodieSparkSqlWriter metasync success or not show details messages log [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #10314:
URL: https://github.com/apache/hudi/pull/10314#discussion_r1423561174
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -975,6 +975,13 @@ class HoodieSparkSqlWriterInternal {
val metaSyncSuccess = metaSync(spark, HoodieWriterUtils.convertMapToHoodieConfig(parameters),
tableInstantInfo.basePath, schema)
+ if (metaSyncSuccess) {
+ log.info("metaSyncSuccess " + tableInstantInfo.instantTime + " successful!")
+ }
Review Comment:
Kind of remember if the meta sync failes, the whole job would just fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7224] HoodieSparkSqlWriter metasync success or not show details messages log [hudi]
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 closed pull request #10314: [HUDI-7224] HoodieSparkSqlWriter metasync success or not show details messages log
URL: https://github.com/apache/hudi/pull/10314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7224] HoodieSparkSqlWriter metasync success or not show details messages log [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10314:
URL: https://github.com/apache/hudi/pull/10314#issuecomment-1851388190
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88b9f8d9518f5afd376479ba9c87a8dd30170ffc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "88b9f8d9518f5afd376479ba9c87a8dd30170ffc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88b9f8d9518f5afd376479ba9c87a8dd30170ffc UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7224] HoodieSparkSqlWriter metasync success or not show details messages log [hudi]
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on code in PR #10314:
URL: https://github.com/apache/hudi/pull/10314#discussion_r1423577968
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -975,6 +975,13 @@ class HoodieSparkSqlWriterInternal {
val metaSyncSuccess = metaSync(spark, HoodieWriterUtils.convertMapToHoodieConfig(parameters),
tableInstantInfo.basePath, schema)
+ if (metaSyncSuccess) {
+ log.info("metaSyncSuccess " + tableInstantInfo.instantTime + " successful!")
+ }
Review Comment:
problem is job would stop with out any error or details to dig cause，these would take more work without the log @danny0405
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -975,6 +975,13 @@ class HoodieSparkSqlWriterInternal {
val metaSyncSuccess = metaSync(spark, HoodieWriterUtils.convertMapToHoodieConfig(parameters),
tableInstantInfo.basePath, schema)
+ if (metaSyncSuccess) {
+ log.info("metaSyncSuccess " + tableInstantInfo.instantTime + " successful!")
+ }
Review Comment:
problem is job would stop with out any error or details to dig cause，these would take more work without the log @danny0405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7224] HoodieSparkSqlWriter metasync success or not show details messages log [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10314:
URL: https://github.com/apache/hudi/pull/10314#issuecomment-1851396191
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88b9f8d9518f5afd376479ba9c87a8dd30170ffc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21467",
"triggerID" : "88b9f8d9518f5afd376479ba9c87a8dd30170ffc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88b9f8d9518f5afd376479ba9c87a8dd30170ffc Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21467)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7224] HoodieSparkSqlWriter metasync success or not show details messages log [hudi]
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 closed pull request #10314: [HUDI-7224] HoodieSparkSqlWriter metasync success or not show details messages log
URL: https://github.com/apache/hudi/pull/10314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org