You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zhangminglei <gi...@git.apache.org> on 2017/06/30 00:59:19 UTC
[GitHub] flink pull request #4229: [FLINK-7038] [docs] Correct misused term to KeyedS...
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/4229
[FLINK-7038] [docs] Correct misused term to KeyedStream
Correct misused term to KeyedStream.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-7038
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4229.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4229
----
commit c77852d306fb0c3b353b69b6be4b50753189f8bf
Author: zhangminglei <zm...@163.com>
Date: 2017-06-30T00:58:12Z
[FLINK-7038] [docs] Correct misused term to KeyedStream
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4229: [FLINK-7038] [docs] Correct misused term to KeyedS...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4229
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4229: [FLINK-7038] [docs] Correct misused term to KeyedStream
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4229
Yep. I will update code again soon enough.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4229: [FLINK-7038] [docs] Correct misused term to KeyedStream
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4229
Okay. I really found many ```KeyedDataStream``` terms existing in flink project under master branch. But there is not a class called it. So, it is very strange. Also the same stuff refers to ```WindowedDataStream``` in flink. Could you check it again and makes sure I am correct or incorrect.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4229: [FLINK-7038] [docs] Correct misused term to KeyedStream
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4229
Yes. That's why the `KeyedDataStream` is a misused term. The actual class is called `KeyedStream`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4229: [FLINK-7038] [docs] Correct misused term to KeyedStream
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4229
Hi, @tzulitai I have updated the code. Please check whether it should add more ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4229: [FLINK-7038] [docs] Correct misused term to KeyedStream
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4229
@zhangminglei thanks for picking this up.
The last time I checked, there's much more misused "KeyedDataStream" terms, both in Javadocs and the documentation. Could you please include fixes for all of those with this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4229: [FLINK-7038] [docs] Correct misused term to KeyedS...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4229#discussion_r125155750
--- Diff: flink-core/src/main/java/org/apache/flink/api/common/state/AppendingState.java ---
@@ -29,7 +29,7 @@
* <p>The state is accessed and modified by user functions, and checkpointed consistently
* by the system as part of the distributed snapshots.
*
- * <p>The state is only accessible by functions applied on a KeyedDataStream. The key is
+ * <p>The state is only accessible by functions applied on a KeyedStream. The key is
--- End diff --
Could you also change these to be actual Javadoc links?
i.e. `{@link KeyedStream}`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4229: [FLINK-7038] [docs] Correct misused term to KeyedStream
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4229
Exactly, Could we create another jira or just do a hotfix for ```WindowedDataStream``` under ```FLINK-7038``` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4229: [FLINK-7038] [docs] Correct misused term to KeyedS...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/4229#discussion_r125158516
--- Diff: flink-core/src/main/java/org/apache/flink/api/common/state/AggregatingState.java ---
@@ -33,7 +33,7 @@
* <p>The state is accessed and modified by user functions, and checkpointed consistently
* by the system as part of the distributed snapshots.
*
- * <p>The state is only accessible by functions applied on a KeyedDataStream. The key is
+ * <p>The state is only accessible by functions applied on a KeyedStream. The key is
--- End diff --
I remember next time as I did not know before like this style. thanks. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4229: [FLINK-7038] [docs] Correct misused term to KeyedS...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4229#discussion_r125155753
--- Diff: flink-core/src/main/java/org/apache/flink/api/common/state/State.java ---
@@ -23,7 +23,7 @@
/**
* Interface that different types of partitioned state must implement.
*
- * <p>The state is only accessible by functions applied on a KeyedDataStream. The key is
+ * <p>The state is only accessible by functions applied on a KeyedStream. The key is
--- End diff --
Could you also change these to be actual Javadoc links?
i.e. `{@link KeyedStream}`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4229: [FLINK-7038] [docs] Correct misused term to KeyedS...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/4229#discussion_r125158619
--- Diff: flink-core/src/main/java/org/apache/flink/api/common/state/AppendingState.java ---
@@ -29,7 +29,7 @@
* <p>The state is accessed and modified by user functions, and checkpointed consistently
* by the system as part of the distributed snapshots.
*
- * <p>The state is only accessible by functions applied on a KeyedDataStream. The key is
+ * <p>The state is only accessible by functions applied on a KeyedStream. The key is
--- End diff --
I probably not set this to ```@link``` , instead, I would set this to ```@code```, because if I use ```link```, it can not be recognized by compiler. I have to add the pom.xml to the module. And I think it is not suitable. What do you think ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4229: [FLINK-7038] [docs] Correct misused term to KeyedStream
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4229
LGTM, merging ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4229: [FLINK-7038] [docs] Correct misused term to KeyedS...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4229#discussion_r125155752
--- Diff: flink-core/src/main/java/org/apache/flink/api/common/state/FoldingState.java ---
@@ -28,7 +28,7 @@
* <p>The state is accessed and modified by user functions, and checkpointed consistently
* by the system as part of the distributed snapshots.
*
- * <p>The state is only accessible by functions applied on a KeyedDataStream. The key is
+ * <p>The state is only accessible by functions applied on a KeyedStream. The key is
--- End diff --
Could you also change these to be actual Javadoc links?
i.e. `{@link KeyedStream}`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4229: [FLINK-7038] [docs] Correct misused term to KeyedS...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4229#discussion_r125155746
--- Diff: flink-core/src/main/java/org/apache/flink/api/common/state/AggregatingState.java ---
@@ -33,7 +33,7 @@
* <p>The state is accessed and modified by user functions, and checkpointed consistently
* by the system as part of the distributed snapshots.
*
- * <p>The state is only accessible by functions applied on a KeyedDataStream. The key is
+ * <p>The state is only accessible by functions applied on a KeyedStream. The key is
--- End diff --
Could you also change these to be actual Javadoc links?
i.e. `{@link KeyedStream}`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---