You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@struts.apache.org by mu...@apache.org on 2008/12/13 16:15:22 UTC
svn commit: r726219 - in
/struts/sandbox/trunk/struts2-javatemplates-plugin/src:
main/java/org/apache/struts2/views/java/simple/SelectHandler.java
test/java/org/apache/struts2/views/java/simple/SelectTest.java
Author: musachy
Date: Sat Dec 13 07:15:22 2008
New Revision: 726219
URL: http://svn.apache.org/viewvc?rev=726219&view=rev
Log:
Fix tabindex bug, add test
Modified:
struts/sandbox/trunk/struts2-javatemplates-plugin/src/main/java/org/apache/struts2/views/java/simple/SelectHandler.java
struts/sandbox/trunk/struts2-javatemplates-plugin/src/test/java/org/apache/struts2/views/java/simple/SelectTest.java
Modified: struts/sandbox/trunk/struts2-javatemplates-plugin/src/main/java/org/apache/struts2/views/java/simple/SelectHandler.java
URL: http://svn.apache.org/viewvc/struts/sandbox/trunk/struts2-javatemplates-plugin/src/main/java/org/apache/struts2/views/java/simple/SelectHandler.java?rev=726219&r1=726218&r2=726219&view=diff
==============================================================================
--- struts/sandbox/trunk/struts2-javatemplates-plugin/src/main/java/org/apache/struts2/views/java/simple/SelectHandler.java (original)
+++ struts/sandbox/trunk/struts2-javatemplates-plugin/src/main/java/org/apache/struts2/views/java/simple/SelectHandler.java Sat Dec 13 07:15:22 2008
@@ -54,7 +54,7 @@
.addIfTrue("disabled", params.get("disabled"))
.addIfTrue("readonly", params.get("readonly"))
.addIfTrue("multiple", params.get("multiple"))
- .addIfExists("tabindex", params.get("tagindex"))
+ .addIfExists("tabindex", params.get("tabindex"))
.addIfExists("id", params.get("id"))
.addIfExists("class", params.get("cssClass"))
.addIfExists("style", params.get("cssStyle"))
Modified: struts/sandbox/trunk/struts2-javatemplates-plugin/src/test/java/org/apache/struts2/views/java/simple/SelectTest.java
URL: http://svn.apache.org/viewvc/struts/sandbox/trunk/struts2-javatemplates-plugin/src/test/java/org/apache/struts2/views/java/simple/SelectTest.java?rev=726219&r1=726218&r2=726219&view=diff
==============================================================================
--- struts/sandbox/trunk/struts2-javatemplates-plugin/src/test/java/org/apache/struts2/views/java/simple/SelectTest.java (original)
+++ struts/sandbox/trunk/struts2-javatemplates-plugin/src/test/java/org/apache/struts2/views/java/simple/SelectTest.java Sat Dec 13 07:15:22 2008
@@ -32,6 +32,26 @@
public class SelectTest extends AbstractTestCase {
private Bean bean1;
+ public void testRenderSelect() {
+ SelectEx tag = new SelectEx(stack, request, response);
+ tag.setName("name_");
+ tag.setSize("10");
+ tag.setDisabled("true");
+ tag.setMultiple("true");
+ tag.setTabindex("1");
+ tag.setId("id_");
+ tag.setCssClass("class");
+ tag.setCssStyle("style");
+ tag.setTitle("title");
+
+ tag.processParams();
+ map.putAll(tag.getParameters());
+ theme.renderTag("select", context);
+ String output = writer.getBuffer().toString();
+ String expected = s("<select name='name_' size='10' tabindex='1' id='id_' class='class' style='style' title='title'></select>");
+ assertEquals(expected, output);
+ }
+
public void testRenderSelectWithHeader() {
SelectEx tag = new SelectEx(stack, request, response);