You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2020/04/08 07:02:23 UTC

[GitHub] [tomcat] michael-o commented on a change in pull request #270: Bulk operation can be used instead of iteration

michael-o commented on a change in pull request #270: Bulk operation can be used instead of iteration
URL: https://github.com/apache/tomcat/pull/270#discussion_r405300164
 
 

 ##########
 File path: java/org/apache/catalina/core/ApplicationContext.java
 ##########
 @@ -1350,9 +1350,7 @@ protected void clearAttributes() {
 
         // Create list of attributes to be removed
         List<String> list = new ArrayList<>();
 
 Review comment:
   Why not pass to the constructor directly?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org