You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by "William A. Rowe, Jr." <wr...@rowe-clan.net> on 2001/08/30 08:18:20 UTC
Re: cvs commit: httpd-2.0/os/unix unixd.h
Two general unix problems to fix before tommorows tag.
From: <wr...@apache.org>
Sent: Thursday, August 30, 2001 12:11 AM
> wrowe 01/08/29 22:11:42
>
> Modified: os/unix unixd.h
> Log:
> No <sys/ipc.h> under cygwin.
>
> Revision Changes Path
> 1.26 +4 -0 httpd-2.0/os/unix/unixd.h
>
> Index: unixd.h
> ===================================================================
> +#ifdef HAVE_SYS_TYPES_H
> #include <sys/types.h>
> +#endif
> +#ifdef HAVE_SYS_IPC_H
> #include <sys/ipc.h>
> +#endif
I know HAVE_SYS_TYPES_H is lying around, dunno if we need a new HAVE_SYS_IPC_H test.
Also, please review and commit (or reject) the following patch;
From: "Stipe Tolj" <to...@wapme-systems.de>
Sent: Saturday, August 11, 2001 6:35 AM
> * srclib/apr/file_io/unix/dir.c: changed a suspicious #ifdef
> statement. Is this a missconfiguration of thread vs. non-thread #ifdef
> exclusion?!?!
--- httpd-2_0_22/srclib/apr/file_io/unix/dir.c Fri Jun 15 20:04:43 2001
+++ httpd-2_0_22-cygwin/srclib/apr/file_io/unix/dir.c Thu Aug 9 10:00:09 2001
@@ -112,7 +112,7 @@
{
apr_status_t ret = 0;
#if APR_HAS_THREADS && defined(_POSIX_THREAD_SAFE_FUNCTIONS) \
- && !defined(READDIR_IS_THREAD_SAFE)
+ && defined(READDIR_IS_THREAD_SAFE)
struct dirent *retent;
ret = readdir_r(thedir->dirstruct, thedir->entry, &retent);
I'm not exactly certain _what_ READDIR_IS_THREAD_SAFE means, that we have a
readdir_r that's useless, or that we have one we aught to use.
Re: cvs commit: httpd-2.0/os/unix unixd.h
Posted by Ryan Bloom <rb...@covalent.net>.
On Wednesday 29 August 2001 23:18, William A. Rowe, Jr. wrote:
> Two general unix problems to fix before tommorows tag.
>
> From: <wr...@apache.org>
> Sent: Thursday, August 30, 2001 12:11 AM
>
> > wrowe 01/08/29 22:11:42
> >
> > Modified: os/unix unixd.h
> > Log:
> > No <sys/ipc.h> under cygwin.
> >
> > Revision Changes Path
> > 1.26 +4 -0 httpd-2.0/os/unix/unixd.h
> >
> > Index: unixd.h
> > ===================================================================
> > +#ifdef HAVE_SYS_TYPES_H
> > #include <sys/types.h>
> > +#endif
> > +#ifdef HAVE_SYS_IPC_H
> > #include <sys/ipc.h>
> > +#endif
>
> I know HAVE_SYS_TYPES_H is lying around, dunno if we need a new
> HAVE_SYS_IPC_H test.
Actually, we don't have either. I'm fixing in the next few minutes.
> Also, please review and commit (or reject) the following patch;
>
> From: "Stipe Tolj" <to...@wapme-systems.de>
> Sent: Saturday, August 11, 2001 6:35 AM
>
> > * srclib/apr/file_io/unix/dir.c: changed a suspicious #ifdef
> > statement. Is this a missconfiguration of thread vs. non-thread #ifdef
> > exclusion?!?!
>
> --- httpd-2_0_22/srclib/apr/file_io/unix/dir.c Fri Jun 15 20:04:43 2001
> +++ httpd-2_0_22-cygwin/srclib/apr/file_io/unix/dir.c Thu Aug 9 10:00:09
> 2001 @@ -112,7 +112,7 @@
> {
> apr_status_t ret = 0;
> #if APR_HAS_THREADS && defined(_POSIX_THREAD_SAFE_FUNCTIONS) \
> - && !defined(READDIR_IS_THREAD_SAFE)
> + && defined(READDIR_IS_THREAD_SAFE)
> struct dirent *retent;
>
> ret = readdir_r(thedir->dirstruct, thedir->entry, &retent);
>
>
> I'm not exactly certain _what_ READDIR_IS_THREAD_SAFE means, that we have a
> readdir_r that's useless, or that we have one we aught to use.
I already explained this in a previous e-mail. :-)
Ryan
______________________________________________________________
Ryan Bloom rbb@apache.org
Covalent Technologies rbb@covalent.net
--------------------------------------------------------------