You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "CRZbulabula (via GitHub)" <gi...@apache.org> on 2025/12/11 11:35:08 UTC
[PR] [AINode] More strict concurrent inference IT [iotdb]
CRZbulabula opened a new pull request, #16898:
URL: https://github.com/apache/iotdb/pull/16898
Rectify the judgement logic of AINode concurrent inference test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AINode] More strict concurrent inference IT [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #16898:
URL: https://github.com/apache/iotdb/pull/16898#issuecomment-3644862729
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=16898) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=16898&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=16898&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=16898&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=16898&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=16898&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=16898)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AINode] More strict concurrent inference IT [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #16898:
URL: https://github.com/apache/iotdb/pull/16898#issuecomment-3641529895
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=16898) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=16898&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=16898&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=16898&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=16898&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=16898&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=16898)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AINode] More strict concurrent inference IT [iotdb]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #16898:
URL: https://github.com/apache/iotdb/pull/16898#discussion_r2610273820
##########
integration-test/src/test/java/org/apache/iotdb/ainode/utils/AINodeTestUtils.java:
##########
@@ -113,13 +116,17 @@ public static void concurrentInference(
while (resultSet.next()) {
outputCnt++;
}
- assertEquals(expectedOutputLength, outputCnt);
+ if (expectedOutputLength != outputCnt) {
+ allPass.set(false);
Review Comment:
When the output count doesn't match the expected length, the test should fail immediately with a descriptive error message. Setting the flag without providing any diagnostic information makes it harder to debug test failures. Consider logging the actual and expected values before setting the flag to false.
```suggestion
fail("Output count mismatch for SQL: " + sql + ". Expected: " + expectedOutputLength + ", but got: " + outputCnt);
```
##########
integration-test/src/test/java/org/apache/iotdb/ainode/utils/AINodeTestUtils.java:
##########
@@ -113,13 +116,17 @@ public static void concurrentInference(
while (resultSet.next()) {
outputCnt++;
}
- assertEquals(expectedOutputLength, outputCnt);
+ if (expectedOutputLength != outputCnt) {
+ allPass.set(false);
+ }
} catch (SQLException e) {
fail(e.getMessage());
+ allPass.set(false);
}
}
} catch (Exception e) {
fail(e.getMessage());
Review Comment:
Calling fail() from within a worker thread will not fail the test as expected. The fail() method throws an AssertionError, but since this is inside a thread's run method, it will only terminate that specific thread without failing the overall test. The allPass flag is correctly set to false, but the fail() call here is ineffective and misleading.
```suggestion
allPass.set(false);
}
}
} catch (Exception e) {
```
##########
integration-test/src/test/java/org/apache/iotdb/ainode/utils/AINodeTestUtils.java:
##########
@@ -129,6 +136,7 @@ public static void concurrentInference(
if (thread.isAlive()) {
fail("Thread timeout after 10 minutes");
}
+ Assert.assertTrue(allPass.get());
}
Review Comment:
The assertion is placed inside the loop and checks allPass after each thread joins. This means if any thread fails, all subsequent iterations of the loop will also fail the assertion. The assertion should be moved outside the loop to check the final state only once after all threads have completed.
```suggestion
}
Assert.assertTrue(allPass.get());
```
##########
integration-test/src/test/java/org/apache/iotdb/ainode/utils/AINodeTestUtils.java:
##########
@@ -113,13 +116,17 @@ public static void concurrentInference(
while (resultSet.next()) {
outputCnt++;
}
- assertEquals(expectedOutputLength, outputCnt);
+ if (expectedOutputLength != outputCnt) {
+ allPass.set(false);
+ }
} catch (SQLException e) {
fail(e.getMessage());
+ allPass.set(false);
}
}
} catch (Exception e) {
fail(e.getMessage());
Review Comment:
Calling fail() from within a worker thread will not fail the test as expected. The fail() method throws an AssertionError, but since this is inside a thread's run method, it will only terminate that specific thread without failing the overall test. The allPass flag is correctly set to false, but the fail() call here is ineffective and misleading.
```suggestion
allPass.set(false);
}
}
} catch (Exception e) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AINode] More strict concurrent inference IT [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #16898:
URL: https://github.com/apache/iotdb/pull/16898#issuecomment-3644647059
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=16898) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=16898&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=16898&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=16898&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=16898&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=16898&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=16898)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AINode] More strict concurrent inference IT [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #16898:
URL: https://github.com/apache/iotdb/pull/16898#issuecomment-3641728471
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/16898?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 39.03%. Comparing base ([`c722aaf`](https://app.codecov.io/gh/apache/iotdb/commit/c722aaf6c8d3bb3b040d537ec8696efecc806156?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e63a1b0`](https://app.codecov.io/gh/apache/iotdb/commit/e63a1b0c47664b396de2f3fed8c6bb55b8b3c513?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #16898 +/- ##
=========================================
Coverage 39.02% 39.03%
Complexity 207 207
=========================================
Files 5021 5021
Lines 333373 333373
Branches 42431 42431
=========================================
+ Hits 130107 130128 +21
+ Misses 203266 203245 -21
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/16898?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AINode] More strict concurrent inference IT [iotdb]
Posted by "CRZbulabula (via GitHub)" <gi...@apache.org>.
CRZbulabula merged PR #16898:
URL: https://github.com/apache/iotdb/pull/16898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org