[jira] [Commented] (MESOS-5037) foreachkey behaviour is not expected in multimap

["haosdent (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-5037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16879902#comment-16879902 ] 

haosdent commented on MESOS-5037:
---------------------------------

Recently we found a high CPU load case when mesos agent reregister. It is caused by this bug as well.
{code}
-    foreachkey (FrameworkID frameworkId,
-               slaves.unreachableTasks.at(slaveInfo.id())) {
+    foreach (FrameworkID frameworkId,
+               slaves.unreachableTasks.at(slaveInfo.id()).keys()) {
{code}

> foreachkey behaviour is not expected in multimap
> ------------------------------------------------
>
>                 Key: MESOS-5037
>                 URL: https://issues.apache.org/jira/browse/MESOS-5037
>             Project: Mesos
>          Issue Type: Bug
>          Components: stout
>            Reporter: haosdent
>            Priority: Major
>              Labels: stout
>
> Currently the {{foreachkey}} implementation is 
> {code}
> #define foreachkey(VAR, COL)                    \
>   foreachpair (VAR, __foreach__::ignore, COL)
> {code}
> This works in most structures. But in multimap, one key may map to multi values. This means there are multi pairs which have same key. So when call {{foreachkey}}, the {{key}} would duplicated when iteration. My idea to solve this is we prefer call {{foreach}} on {{(COL).keys()}} if {{keys()}} method exists in {{COL}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)