You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/07 09:25:35 UTC

[GitHub] [airflow] potiuk opened a new pull request #7377: [AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible

potiuk opened a new pull request #7377: [AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible
URL: https://github.com/apache/airflow/pull/7377
 
 
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ddelange commented on issue #7377: [AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible

Posted by GitBox <gi...@apache.org>.
ddelange commented on issue #7377: [AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible
URL: https://github.com/apache/airflow/pull/7377#issuecomment-583378252
 
 
   ref https://github.com/pallets/flask/pull/3489
   
   ```
   $ pipgrip --tree -vvv flask_admin
   
   flask-admin (1.5.4)
   ├── flask>=0.7 (1.1.1)
   │   ├── click>=5.1 (7.0)
   │   ├── itsdangerous>=0.24 (1.1.0)
   │   ├── jinja2>=2.10.1 (2.11.1)
   │   │   └── markupsafe>=0.23 (1.1.1)
   │   └── werkzeug>=0.15 (1.0.0)
   └── wtforms (2.2.1)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #7377: [AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7377: [AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible
URL: https://github.com/apache/airflow/pull/7377#issuecomment-583312365
 
 
   Might be solved differently https://apache-airflow.slack.com/archives/CCQ7EGB1P/p1581028413361000

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] davidism commented on issue #7377: [AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible

Posted by GitBox <gi...@apache.org>.
davidism commented on issue #7377: [AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible
URL: https://github.com/apache/airflow/pull/7377#issuecomment-583403976
 
 
   We're planning to add some imports back compatibility. Sorry for the issue and thanks for your patience.
   
   If you have any insight into which dependencies are raising deprecation warnings with werkzeug 0.16.1, that would be really helpful.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #7377: [AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7377: [AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible
URL: https://github.com/apache/airflow/pull/7377#issuecomment-583317040
 
 
   > For the 1-10 release branch at least we can't upgrade: Flask-Admin hasn't yet published the fix [flask-admin/flask-admin#1951](https://github.com/flask-admin/flask-admin/issues/1951)
   
   I think no matter what, it's safer to downgrade werkzeug for 1.10.x rather than upgrade flask.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on issue #7377: [AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible

Posted by GitBox <gi...@apache.org>.
ashb commented on issue #7377: [AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible
URL: https://github.com/apache/airflow/pull/7377#issuecomment-583311568
 
 
   I'd like to try upgrading rather then pinning first. (I'll make the pr now)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] tooptoop4 commented on issue #7377: [AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible

Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on issue #7377: [AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible
URL: https://github.com/apache/airflow/pull/7377#issuecomment-583372633
 
 
   just missed 1.10.8 release :(

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on issue #7377: [AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible

Posted by GitBox <gi...@apache.org>.
ashb commented on issue #7377: [AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible
URL: https://github.com/apache/airflow/pull/7377#issuecomment-583315363
 
 
   For the 1-10 release branch at least we can't upgrade: Flask-Admin hasn't yet published the fix https://github.com/flask-admin/flask-admin/issues/1951

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] davidism removed a comment on issue #7377: [AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible

Posted by GitBox <gi...@apache.org>.
davidism removed a comment on issue #7377: [AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible
URL: https://github.com/apache/airflow/pull/7377#issuecomment-583403976
 
 
   We're planning to add some imports back compatibility. Sorry for the issue and thanks for your patience.
   
   If you have any insight into which dependencies are raising deprecation warnings with werkzeug 0.16.1, that would be really helpful.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7377: [AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7377: [AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible
URL: https://github.com/apache/airflow/pull/7377#issuecomment-583337642
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7377?src=pr&el=h1) Report
   > Merging [#7377](https://codecov.io/gh/apache/airflow/pull/7377?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f46be8152a4d89c57db4ca46f5b3339e4876b723?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7377/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7377?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7377      +/-   ##
   ==========================================
   - Coverage   86.35%   86.07%   -0.29%     
   ==========================================
     Files         871      871              
     Lines       40636    40636              
   ==========================================
   - Hits        35091    34976     -115     
   - Misses       5545     5660     +115
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7377?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7377/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7377/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7377/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7377/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7377/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `70.21% <0%> (-23.41%)` | :arrow_down: |
   | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/7377/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `88.12% <0%> (+0.19%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7377?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7377?src=pr&el=footer). Last update [f46be81...ad18e97](https://codecov.io/gh/apache/airflow/pull/7377?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on issue #7377: [AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible

Posted by GitBox <gi...@apache.org>.
ashb commented on issue #7377: [AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible
URL: https://github.com/apache/airflow/pull/7377#issuecomment-583317492
 
 
   Oh FAB is broken too because of it's dep on `flask-babel<1`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on issue #7377: [AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible

Posted by GitBox <gi...@apache.org>.
ashb commented on issue #7377: [AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible
URL: https://github.com/apache/airflow/pull/7377#issuecomment-583317027
 
 
   Lets merge this one and push it out, then I'll look at unpinning/upgrading all the deps as needed on master to update it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk merged pull request #7377: [AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7377: [AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible
URL: https://github.com/apache/airflow/pull/7377
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services