[GitHub] [spark] gaborgsomogyi edited a comment on pull request #28368: [SPARK-31575][SQL] Synchronise global JVM security configuration modification

[GitBox <gi...@apache.org>]

gaborgsomogyi edited a comment on pull request #28368:
URL: https://github.com/apache/spark/pull/28368#issuecomment-625816367


   I've double checked. `Configuration` static methods are using `Configuration.class` as sync object. If we take the classical deadlock example where 2 threads are locking 2 locks in the opposite order:
   * Thread1 locks `SecurityConfigurationLock`
   * Thread2 locks `Configuration` (it reads something)
   * Thread1 tries to lock `Configuration` <= block here
   * Thread2 does it's job and release `Configuration` lock
   * Thread1 goes forward, locks and unlocks `Configuration` and finally release the `SecurityConfigurationLock`
   
   I think problem would appear when `Configuration` would depend on `SecurityConfigurationLock`, since that is a JVM feature this can't be possible.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org