[Impala-ASF-CR] IMPALA-12066: Avoid missing updates due to skipping

["ttttttz (Code Review)" <ge...@cloudera.org>]

ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/19751 )

Change subject: IMPALA-12066: Avoid missing updates due to skipping
......................................................................


Patch Set 5:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/19751/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19751/5//COMMIT_MSG@20
PS5, Line 20: catalog_max_lock_delay_topic_updates
> The name doesn't indicate this is a duration, not a count. "catalog_topic_u
Ack


http://gerrit.cloudera.org:8080/#/c/19751/5/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:

http://gerrit.cloudera.org:8080/#/c/19751/5/be/src/catalog/catalog-server.cc@135
PS5, Line 135: 240000
> How do we determine the value of this? Is it based on topic_update_tbl_max_
Ack


http://gerrit.cloudera.org:8080/#/c/19751/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java:

http://gerrit.cloudera.org:8080/#/c/19751/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1512
PS5, Line 1512: new Date().getTime()
> System.currentTimeMillis() is better
Ack


http://gerrit.cloudera.org:8080/#/c/19751/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1545
PS5, Line 1545: new Date().getTime()
> System.currentTimeMillis() is better
Ack


http://gerrit.cloudera.org:8080/#/c/19751/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1549
PS5, Line 1549:           tbl.getFullName(), tbl.getCatalogVersion(), ctx.fromVersion, ctx.toVersion);
> Please also add "delay" in the log.
Ack


http://gerrit.cloudera.org:8080/#/c/19751/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1553
PS5, Line 1553:         topicUpdateLog_.getOrCreateLogEntry(tableUniqueName);
> nit: merge line 1552 and 1553 into one line
Ack



-- 
To view, visit http://gerrit.cloudera.org:8080/19751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a21edaea21b95723e567ddee5e1f857c0e2b087
Gerrit-Change-Number: 19751
Gerrit-PatchSet: 5
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 07 May 2023 12:01:53 +0000
Gerrit-HasComments: Yes