[jira] Commented: (WICKET-3010) RequestCycle.setResponsePage should defer switching to BookmarkableRequestTarget until finishing responding to currrent target

["Vladimir Kovalyuk (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-3010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902335#action_12902335 ] 

Vladimir Kovalyuk commented on WICKET-3010:
-------------------------------------------

JS works only for bookmarkable redirects. It doesn't seem to work for new Page() case which is sometimes better that parsing PageParameters.

I suggest revising it later because there are the other concerns. For instance one has always pass AjaxRequestTarget through all the methods in the call tree. Or for instance RequestCycle.getResponsePage will return subject of redirecting instead of the current page and one will always has to pass some Component in order to get the page from it. I believe WiQuery has many pitfalls around that.

Any guarantees on overriding WebApplication.logResponseTarget(IRequestTarget target)? Or am I missing the other Wicket request lifecycle callback methods?


> RequestCycle.setResponsePage should defer switching to BookmarkableRequestTarget until finishing responding to currrent target
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3010
>                 URL: https://issues.apache.org/jira/browse/WICKET-3010
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.4.10
>            Reporter: Vladimir Kovalyuk
>            Assignee: Igor Vaynberg
>
> Once setResponsePage is called the AjaxRequestTarget is pushed down in the list of request targets and AjaxRequestTarget won't be called anymore because AbstractRequestCycleProcessor.respond invokes the current request target only.
> My page has some ajax links that delegates handling to different module and link does not know whether redirect happens. The link still has to update some components. But in case of redirect all the updates aren't applied and backbuttoning shows old state (actually with ajax indicator covering all the page so any element is not clickable).
> I believe it makes sence to defer switching to different request target until finishing responding on ajax request.
> I found WebApplication.logResponseTarget(IRequestTarget target) as the place where I can actually apply deferred redirect. Please don't kill or make this method  final.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.