[GitHub] dhlaluku commented on a change in pull request #2848: Vmware offline migration

[GitBox <gi...@apache.org>]

dhlaluku commented on a change in pull request #2848: Vmware offline migration
URL: https://github.com/apache/cloudstack/pull/2848#discussion_r248172351
 
 

 ##########
 File path: api/src/main/java/org/apache/cloudstack/api/command/admin/vm/MigrateVMCmd.java
 ##########
 @@ -119,13 +119,7 @@ public String getEventType() {
 
     @Override
     public String getEventDescription() {
-        if (getHostId() != null) {
-            return "Attempting to migrate VM Id: " + this._uuidMgr.getUuid(VirtualMachine.class, getVirtualMachineId()) + " to host Id: " + this._uuidMgr.getUuid(Host.class, getHostId());
-        } else if (getStoragePoolId() != null) {
-            return "Attempting to migrate VM Id: " + this._uuidMgr.getUuid(VirtualMachine.class, getVirtualMachineId()) + " to storage pool Id: " + this._uuidMgr.getUuid(StoragePool.class, getStoragePoolId());
-        } else {
-            return "Attempting to migrate VM Id: " + this._uuidMgr.getUuid(VirtualMachine.class, getVirtualMachineId());
-        }
+        return "Attempting to migrate VM Id: " + getVirtualMachineId() + " to host Id: " + getHostId();
 
 Review comment:
   @mike-tutkowski I have re-analyzed this and getHostID() can be null considering that a VM can either be migrated to a host or storage pool, both of which are optional parameters. I will revert back this change to cater for the migrate VM to either host or storage pool. /CC @DaanHoogland 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services