[GitHub] [james-project] Arsnael commented on a diff in pull request #1648: JAMES-3929 Upgrade to opensearch-java 2.6.0

["Arsnael (via GitHub)" <gi...@apache.org>]

Arsnael commented on code in PR #1648:
URL: https://github.com/apache/james-project/pull/1648#discussion_r1296760431


##########
backends-common/opensearch/pom.xml:
##########
@@ -71,6 +71,18 @@
             <groupId>org.apache.commons</groupId>
             <artifactId>commons-configuration2</artifactId>
         </dependency>
+        <!-- Needed for opensearch-java dependency -->
+        <dependency>
+            <groupId>org.apache.httpcomponents.client5</groupId>
+            <artifactId>httpclient5</artifactId>
+            <version>5.1.4</version>
+        </dependency>
+        <!-- Needed for opensearch-java dependency -->
+        <dependency>
+            <groupId>org.apache.httpcomponents.core5</groupId>
+            <artifactId>httpcore5</artifactId>
+            <version>5.1.5</version>
+        </dependency>

Review Comment:
   Yes. Just took what was on the java opensearch client side. If you look at the respective versions at maven central as well, you can see those two libs are not strictly coupled:
   
   - https://mvnrepository.com/artifact/org.apache.httpcomponents.client5/httpclient5
   - https://mvnrepository.com/artifact/org.apache.httpcomponents.core5/httpcore5
   
   You can see there is no 5.1.5 version for httpclient5, it stops at 1.5.4 (similar with the current 5.2.x upper version actually)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org