[jira] [Commented] (CB-5500) customised lib urls are not used when lazy loading libs

["Wei Li (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-5500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13834851#comment-13834851 ] 

Wei Li commented on CB-5500:
----------------------------

Looks like this is actually not a bug. 

After reading more source code, looks like the custom uri only supports library path on local file system. It doesn't support downloading library templates from remote locations other than cordova. 

Close this.

> customised lib urls are not used when lazy loading libs 
> --------------------------------------------------------
>
>                 Key: CB-5500
>                 URL: https://issues.apache.org/jira/browse/CB-5500
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI
>    Affects Versions: 3.2.0
>         Environment: All
>            Reporter: Wei Li
>            Priority: Minor
>              Labels: patch
>
> When creating a new cordova project using the cli tool, I specified customised uri paths for the libs. However, when I ran the platform add command, cordova cli is not downloading the lib from the uri I specified. It still tries to download from the default url.
> The cause of the problem is found in function
> has_custom_path
> in src/config.js file. Around this line:
> if (uri.protocol && uri.protocol[1] ==':')
> The value of protocol will be like "http:" or "https:", according to nodejs document. 
> The value of uri.protocol[1] will never equal to ":", so the above statement will always be false.
> I think the fix should be like this:
> if (uri.protocol && uri.protocol[uri.protocol.length - 1] ==':')
> make sure the protocol ends with ":".
> A pull request has created to fix this issue:
> https://github.com/apache/cordova-cli/pull/102



--
This message was sent by Atlassian JIRA
(v6.1#6144)