You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slawekjaranowski (via GitHub)" <gi...@apache.org> on 2025/10/25 14:32:59 UTC
[PR] Support classpath in Basedir [maven-plugin-testing]
slawekjaranowski opened a new pull request, #234:
URL: https://github.com/apache/maven-plugin-testing/pull/234
Allow to provide classpath in Basedir instead of path to project
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support classpath in Basedir [maven-plugin-testing]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #234:
URL: https://github.com/apache/maven-plugin-testing/pull/234#discussion_r2466253781
##########
maven-plugin-testing-harness/src/test/java/org/apache/maven/plugin/testing/ParametersMojoTest.java:
##########
@@ -116,4 +116,12 @@ void basedirInjectedWithBasedirAnnotation(ParametersMojo mojo) {
assertEquals("i-have-a-basedir-set-by-annotation", mojo.getPlain());
assertDoesNotThrow(mojo::execute);
}
Review Comment:
@sparsick there is tests for relative path of `Basedir`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support classpath in Basedir [maven-plugin-testing]
Posted by "sparsick (via GitHub)" <gi...@apache.org>.
sparsick commented on PR #234:
URL: https://github.com/apache/maven-plugin-testing/pull/234#issuecomment-3450352765
Do you also support basedir for absolute / relative path? If it is, then I would add tests for that for demonstrating it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support classpath in Basedir [maven-plugin-testing]
Posted by "sparsick (via GitHub)" <gi...@apache.org>.
sparsick commented on code in PR #234:
URL: https://github.com/apache/maven-plugin-testing/pull/234#discussion_r2466293237
##########
maven-plugin-testing-harness/src/test/java/org/apache/maven/plugin/testing/ParametersMojoTest.java:
##########
@@ -116,4 +116,12 @@ void basedirInjectedWithBasedirAnnotation(ParametersMojo mojo) {
assertEquals("i-have-a-basedir-set-by-annotation", mojo.getPlain());
assertDoesNotThrow(mojo::execute);
}
Review Comment:
Sorry, didn't see it. 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support classpath in Basedir [maven-plugin-testing]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #234:
URL: https://github.com/apache/maven-plugin-testing/pull/234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org