You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by d2r <gi...@git.apache.org> on 2015/12/03 16:56:04 UTC
[GitHub] storm pull request: [STORM-1364] logs the storm version when start...
GitHub user d2r opened a pull request:
https://github.com/apache/storm/pull/916
[STORM-1364] logs the storm version when starting
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/d2r/storm storm-1364-deamons-log-version-on-start
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/916.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #916
----
commit b52988ab1d6c3ef853769ebb272e27caaf55ec38
Author: Derek Dagit <de...@yahoo-inc.com>
Date: 2015-12-03T15:55:26Z
logs the storm version when starting
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1364] logs the storm version when start...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/916#issuecomment-161782690
closing/reopening to trigger another ci build
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1364] logs the storm version when start...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/916#issuecomment-161784128
+1 looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1364] logs the storm version when start...
Posted by darionyaphet <gi...@git.apache.org>.
Github user darionyaphet commented on the pull request:
https://github.com/apache/storm/pull/916#issuecomment-162433815
It seems just add some log info
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1364] logs the storm version when start...
Posted by d2r <gi...@git.apache.org>.
GitHub user d2r reopened a pull request:
https://github.com/apache/storm/pull/916
[STORM-1364] logs the storm version when starting
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/d2r/storm storm-1364-deamons-log-version-on-start
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/916.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #916
----
commit b52988ab1d6c3ef853769ebb272e27caaf55ec38
Author: Derek Dagit <de...@yahoo-inc.com>
Date: 2015-12-03T15:55:26Z
logs the storm version when starting
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1364] logs the storm version when start...
Posted by jerrypeng <gi...@git.apache.org>.
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/916#issuecomment-162589790
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1364] logs the storm version when start...
Posted by unsleepy22 <gi...@git.apache.org>.
Github user unsleepy22 commented on the pull request:
https://github.com/apache/storm/pull/916#issuecomment-161705726
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1364] logs the storm version when start...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/916#issuecomment-161800044
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1364] logs the storm version when start...
Posted by d2r <gi...@git.apache.org>.
GitHub user d2r reopened a pull request:
https://github.com/apache/storm/pull/916
[STORM-1364] logs the storm version when starting
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/d2r/storm storm-1364-deamons-log-version-on-start
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/916.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #916
----
commit b52988ab1d6c3ef853769ebb272e27caaf55ec38
Author: Derek Dagit <de...@yahoo-inc.com>
Date: 2015-12-03T15:55:26Z
logs the storm version when starting
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1364] logs the storm version when start...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/916#issuecomment-162618653
Created [STORM-1377](https://issues.apache.org/jira/browse/STORM-1377) for nimbus-auth-test issues.
Checks have passed, so I will merge this since there are binding +1s and no unresolved issues after 1 day.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1364] logs the storm version when start...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/916
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1364] logs the storm version when start...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/916#issuecomment-161999062
3 failures in nimbus-auth-test for storm-core on jdk8 only. Need to look at why it happened.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1364] logs the storm version when start...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/916#issuecomment-162593739
> 3 failures in nimbus-auth-test for storm-core on jdk8 only. Need to look at why it happened.
I did look at these test failures. They are likely not related to this change. There is a race condition whenever we try to get an ephemeral port from the system such that sometimes multiple tests launch nimbus nodes with the same port.
Separately I will look into tightening the race and/or locking such that each test case will use only the test nimbus instance that is configured especially for it.
In the meantime, I will close and re-open this pull request to start another travis-ci build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1364] logs the storm version when start...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/916#issuecomment-161728319
```
testPollWhileThereAreNoDataAvailable(backtype.storm.utils.ShellBoltMessageQueueTest) Time elapsed: 1.005 sec <<< FAILURE!
junit.framework.AssertionFailedError: null
at junit.framework.Assert.fail(Assert.java:55)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework.Assert.assertTrue(Assert.java:31)
at junit.framework.TestCase.assertTrue(TestCase.java:201)
at backtype.storm.utils.ShellBoltMessageQueueTest.testPollWhileThereAreNoDataAvailable(ShellBoltMessageQueueTest.java:55)
```
This is the test I see failing both in this pull request and also on my travis
ci setup.
It does not seem related to my changes, but it is causing the overall check to
fail for storm-core, and that causes the other modules not to be tested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1364] logs the storm version when start...
Posted by wuchong <gi...@git.apache.org>.
Github user wuchong commented on the pull request:
https://github.com/apache/storm/pull/916#issuecomment-161851976
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1364] logs the storm version when start...
Posted by d2r <gi...@git.apache.org>.
Github user d2r closed the pull request at:
https://github.com/apache/storm/pull/916
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1364] logs the storm version when start...
Posted by d2r <gi...@git.apache.org>.
Github user d2r closed the pull request at:
https://github.com/apache/storm/pull/916
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---