(pinot) 06/06: fixed note in SpecialValueTransformer.

[sn...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

snlee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git

commit f79b618141e07c140663791959d96956ad91d811
Author: Aishik <ai...@startree.ai>
AuthorDate: Thu Nov 23 23:33:52 2023 +0530

    fixed note in SpecialValueTransformer.
---
 .../segment/local/recordtransformer/SpecialValueTransformer.java     | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/SpecialValueTransformer.java b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/SpecialValueTransformer.java
index 3383803194..29596e0935 100644
--- a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/SpecialValueTransformer.java
+++ b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/SpecialValueTransformer.java
@@ -35,8 +35,9 @@ import org.slf4j.LoggerFactory;
  *   <li>Negative zero (-0.0) should be converted to 0.0</li>
  *   <li>NaN should be converted to default null</li>
  * </ul>
- * <p>NOTE: should put this after the {@link DataTypeTransformer} so that all values follow the data types in
- * {@link FieldSpec}.
+ * <p>NOTE: should put this after the {@link DataTypeTransformer} so that we already have the values complying
+ * with the schema before handling special values and before {@link NullValueTransformer} so that it transforms
+ * all the null values properly.
  */
 public class SpecialValueTransformer implements RecordTransformer {
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org