You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by dr...@apache.org on 2007/10/26 17:26:31 UTC

svn commit: r588686 - /myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/MessageRenderer.java

Author: drobinson
Date: Fri Oct 26 08:26:30 2007
New Revision: 588686

URL: http://svn.apache.org/viewvc?rev=588686&view=rev
Log:
TRINIDAD-144, TRINIDAD-783
Cleaned up message renderer code and consolidated rendering logic for server-side and client-side validation into single block.  Removed duplicate spans for client-side validation, so issues with duplicate messages should be resolved.  Also cleaned up default style for messages to remove the use of p_OraDisplayBlock from OraInlineInfoText style, so strange layout behavior should be resolve in IE.

Modified:
    myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/MessageRenderer.java

Modified: myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/MessageRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/MessageRenderer.java?rev=588686&r1=588685&r2=588686&view=diff
==============================================================================
--- myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/MessageRenderer.java (original)
+++ myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/MessageRenderer.java Fri Oct 26 08:26:30 2007
@@ -181,12 +181,12 @@
         // Output the server-side message
         renderPossiblyFormattedText(context, message);
       }
-      else 
-      {
-        // Hide element ready for client-side validation
-        writer.writeAttribute(XhtmlConstants.STYLE_ATTRIBUTE, 
-            "display:none;", null);
-      }
+//      else 
+//      {
+//        // Hide element ready for client-side validation
+//        writer.writeAttribute(XhtmlConstants.STYLE_ATTRIBUTE, 
+//            "display:none;", null);
+//      }
       
       writer.endElement(XhtmlConstants.SPAN_ELEMENT);
     }