You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/28 15:15:36 UTC

[GitHub] [apisix] imjoey commented on a change in pull request #4151: fix(response-rewrite): properly base64 process the nil and empty body

imjoey commented on a change in pull request #4151:
URL: https://github.com/apache/apisix/pull/4151#discussion_r622282090



##########
File path: t/plugin/response-rewrite.t
##########
@@ -629,3 +629,50 @@ hello world
 200
 --- no_error_log
 [error]
+
+
+
+=== TEST 22: set an empty body with setting body_base64 to true
+--- config
+    location /t {
+        content_by_lua_block {
+            local plugin = require("apisix.plugins.response-rewrite")
+            local ok, err = plugin.check_schema({
+                            body = "",
+                            body_base64 =  true

Review comment:
       @tokers thank you very much. 😄 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org