You are viewing a plain text version of this content. The canonical link for it is here.
Posted to ftpserver-dev@incubator.apache.org by "Steve Jones (JIRA)" <ji...@apache.org> on 2007/05/18 18:28:16 UTC
[jira] Created: (FTPSERVER-88) FEAT command response format is
incorrect
FEAT command response format is incorrect
-----------------------------------------
Key: FTPSERVER-88
URL: https://issues.apache.org/jira/browse/FTPSERVER-88
Project: FtpServer
Issue Type: Bug
Components: Core
Reporter: Steve Jones
The FEAT command does not put a space character before each feature listing, this is required as per:
http://www.rfc-archive.org/getrfc.php?rfc=2389
Here's the grammar (from the RFC):
feat-response = error-response / no-features / feature-listing
no-features = "211" SP *TCHAR CRLF
feature-listing = "211-" *TCHAR CRLF
1*( SP feature CRLF )
"211 End" CRLF
feature = feature-label [ SP feature-parms ]
feature-label = 1*VCHAR
feature-parms = 1*TCHAR
Heres the example they provide:
C> feat
S> 211-Extensions supported:
S> MLST size*;create;modify*;perm;media-type
S> SIZE
S> COMPRESSION
S> MDTM
S> 211 END
Here's what FtpServer would output for the above features:
C> feat
S> 211-Extensions supported:
S> MLST size*;create;modify*;perm;media-type
S> SIZE
S> COMPRESSION
S> MDTM
S> 211 END
Perhaps a variant of "DefaultFtpReply" that does not "trim()" each line is required for this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FTPSERVER-88) FEAT command response format is
incorrect
Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niklas Gustavsson closed FTPSERVER-88.
--------------------------------------
Resolution: Fixed
Fix Version/s: 1.0-M2
Assignee: Niklas Gustavsson
This should now be fixed, thanks for the report!
commit -m "Fix for bug where the FEAT response would not contain the starting space character on each line. Reported by Steve Jones. (FTPSERVER-88)" C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/DefaultFtpReply.java C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/message/FtpStatus.properties C:/home/niklas/workspaces/apache/ftpserver/core/src/test/org/apache/ftpserver/clienttests/FeatTest.java C:/home/niklas/workspaces/apache/ftpserver/core/src/test/org/apache/ftpserver/DefaultFtpReplyTest.java C:/home/niklas/workspaces/apache/ftpserver/core/src/test/org/apache/ftpserver/FtpResponseImplTest.java
Sending C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/DefaultFtpReply.java
Sending C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/message/FtpStatus.properties
Adding C:/home/niklas/workspaces/apache/ftpserver/core/src/test/org/apache/ftpserver/clienttests/FeatTest.java
Adding C:/home/niklas/workspaces/apache/ftpserver/core/src/test/org/apache/ftpserver/DefaultFtpReplyTest.java
Deleting C:/home/niklas/workspaces/apache/ftpserver/core/src/test/org/apache/ftpserver/FtpResponseImplTest.java
Transmitting file data ...
Committed revision 540925.
> FEAT command response format is incorrect
> -----------------------------------------
>
> Key: FTPSERVER-88
> URL: https://issues.apache.org/jira/browse/FTPSERVER-88
> Project: FtpServer
> Issue Type: Bug
> Components: Core
> Reporter: Steve Jones
> Assigned To: Niklas Gustavsson
> Fix For: 1.0-M2
>
>
> The FEAT command does not put a space character before each feature listing, this is required as per:
> http://www.rfc-archive.org/getrfc.php?rfc=2389
> Here's the grammar (from the RFC):
> feat-response = error-response / no-features / feature-listing
> no-features = "211" SP *TCHAR CRLF
> feature-listing = "211-" *TCHAR CRLF
> 1*( SP feature CRLF )
> "211 End" CRLF
> feature = feature-label [ SP feature-parms ]
> feature-label = 1*VCHAR
> feature-parms = 1*TCHAR
> Heres the example they provide:
> C> feat
> S> 211-Extensions supported:
> S> MLST size*;create;modify*;perm;media-type
> S> SIZE
> S> COMPRESSION
> S> MDTM
> S> 211 END
> Here's what FtpServer would output for the above features:
> C> feat
> S> 211-Extensions supported:
> S> MLST size*;create;modify*;perm;media-type
> S> SIZE
> S> COMPRESSION
> S> MDTM
> S> 211 END
> Perhaps a variant of "DefaultFtpReply" that does not "trim()" each line is required for this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.