You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ij...@apache.org on 2021/06/28 13:28:57 UTC
[kafka] branch 2.4 updated: KAFKA-12790: Remove
SslTransportLayerTest.testUnsupportedTlsVersion (#10922)
This is an automated email from the ASF dual-hosted git repository.
ijuma pushed a commit to branch 2.4
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/2.4 by this push:
new 851124d KAFKA-12790: Remove SslTransportLayerTest.testUnsupportedTlsVersion (#10922)
851124d is described below
commit 851124d347a0c0333a4edeb2742d1cc90cca3a3f
Author: Ismael Juma <is...@juma.me.uk>
AuthorDate: Sun Jun 27 14:15:19 2021 -0700
KAFKA-12790: Remove SslTransportLayerTest.testUnsupportedTlsVersion (#10922)
Support for TLS 1.0/1.1 was disabled in recent versions of Java 8/11
and all versions of 16 causing this test to fail.
It is possible to make it work by updating the relevant security
property,
but it has to be done before the affected classes are loaded and it can
not be disabled after that. Given the low value of the test, we remove
it.
Reviewers: Rajini Sivaram <ra...@googlemail.com>, Luke Chen
<sh...@gmail.com>
---
.../kafka/common/network/SslTransportLayerTest.java | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java b/clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java
index d25fa61..52077ea 100644
--- a/clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java
+++ b/clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java
@@ -520,24 +520,6 @@ public class SslTransportLayerTest {
}
/**
- * Tests that connections cannot be made with unsupported TLS versions
- */
- @Test
- public void testUnsupportedTLSVersion() throws Exception {
- String node = "0";
- sslServerConfigs.put(SslConfigs.SSL_ENABLED_PROTOCOLS_CONFIG, Arrays.asList("TLSv1.2"));
- server = createEchoServer(SecurityProtocol.SSL);
-
- sslClientConfigs.put(SslConfigs.SSL_ENABLED_PROTOCOLS_CONFIG, Arrays.asList("TLSv1.1"));
- createSelector(sslClientConfigs);
- InetSocketAddress addr = new InetSocketAddress("localhost", server.port());
- selector.connect(node, addr, BUFFER_SIZE, BUFFER_SIZE);
-
- NetworkTestUtils.waitForChannelClose(selector, node, ChannelState.State.AUTHENTICATION_FAILED);
- server.verifyAuthenticationMetrics(0, 1);
- }
-
- /**
* Tests that connections cannot be made with unsupported TLS cipher suites
*/
@Test