You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/05/20 10:40:42 UTC
[GitHub] [kylin] zhangayqian opened a new pull request #1222: KYLIN-3698 some enhancement for check-env.sh
zhangayqian opened a new pull request #1222:
URL: https://github.com/apache/kylin/pull/1222
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
- [ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If this change need a document change, I will prepare another pr against the `document` branch
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] coveralls commented on pull request #1222: KYLIN-3698 some enhancement for check-env.sh
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #1222:
URL: https://github.com/apache/kylin/pull/1222#issuecomment-631408827
## Pull Request Test Coverage Report for [Build 5921](https://coveralls.io/builds/30915293)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **6** unchanged lines in **3** files lost coverage.
* Overall coverage decreased (**-0.001%**) to **27.293%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/30915293/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L146) | 1 | 56.82% |
| [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/30915293/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/30915293/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% |
<!-- | **Total:** | **6** | | -->
| Totals | [](https://coveralls.io/builds/30915293) |
| :-- | --: |
| Change from base [Build 5911](https://coveralls.io/builds/30861301): | -0.001% |
| Covered Lines: | 24352 |
| Relevant Lines: | 89225 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zhangayqian commented on a change in pull request #1222: KYLIN-3698 some enhancement for check-env.sh
Posted by GitBox <gi...@apache.org>.
zhangayqian commented on a change in pull request #1222:
URL: https://github.com/apache/kylin/pull/1222#discussion_r443982825
##########
File path: build/bin/kylin.sh
##########
@@ -40,16 +40,10 @@ function retrieveDependency() {
source ${dir}/cached-hive-dependency.sh
source ${dir}/cached-hbase-dependency.sh
source ${dir}/cached-hadoop-conf-dir.sh
- source ${dir}/cached-kafka-dependency.sh
Review comment:
Because these three checks are put in check-env.sh, there is no need to check them again here.
But now it is found that some tool commands, such as `bin/kylin.sh org.apache.kylin.source.kafka.util.KafkaSampleProducer`, require Kafka's dependency. However, the check-env.sh is not executed when using this command, which makes it unable to load Kafka's dependency.
This is my negligence. It should not be removed here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on a change in pull request #1222: KYLIN-3698 some enhancement for check-env.sh
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on a change in pull request #1222:
URL: https://github.com/apache/kylin/pull/1222#discussion_r443964079
##########
File path: build/bin/kylin.sh
##########
@@ -40,16 +40,10 @@ function retrieveDependency() {
source ${dir}/cached-hive-dependency.sh
source ${dir}/cached-hbase-dependency.sh
source ${dir}/cached-hadoop-conf-dir.sh
- source ${dir}/cached-kafka-dependency.sh
Review comment:
Why should remove these lines?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] nichunen merged pull request #1222: KYLIN-3698 some enhancement for check-env.sh
Posted by GitBox <gi...@apache.org>.
nichunen merged pull request #1222:
URL: https://github.com/apache/kylin/pull/1222
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] codecov-commenter commented on pull request #1222: KYLIN-3698 some enhancement for check-env.sh
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1222:
URL: https://github.com/apache/kylin/pull/1222#issuecomment-631407258
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1222?src=pr&el=h1) Report
> Merging [#1222](https://codecov.io/gh/apache/kylin/pull/1222?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/7886a2498178ded085497d6204b4b367f56ce0c8&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1222?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1222 +/- ##
============================================
- Coverage 24.85% 24.84% -0.01%
+ Complexity 6266 6264 -2
============================================
Files 1453 1453
Lines 89225 89225
Branches 12456 12456
============================================
- Hits 22175 22171 -4
- Misses 64874 64876 +2
- Partials 2176 2178 +2
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1222?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1222/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0.00%> (-4.77%)` | `5.00% <0.00%> (-1.00%)` | |
| [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1222/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0.00%> (-2.31%)` | `0.00% <0.00%> (ø%)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1222/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `50.00% <0.00%> (-2.28%)` | `7.00% <0.00%> (-1.00%)` | |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1222/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0.00%> (+0.91%)` | `7.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1222?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1222?src=pr&el=footer). Last update [7886a24...e2e51bb](https://codecov.io/gh/apache/kylin/pull/1222?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zhangayqian commented on pull request #1222: KYLIN-3698 some enhancement for check-env.sh
Posted by GitBox <gi...@apache.org>.
zhangayqian commented on pull request #1222:
URL: https://github.com/apache/kylin/pull/1222#issuecomment-631397290
Evidence:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org