You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Ajay Yadava <aj...@gmail.com> on 2015/08/04 16:50:41 UTC

Review Request 37077: FALCON-1359 Fix output format of Feed Instance Listing API

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37077/
-----------------------------------------------------------

Review request for Falcon.


Bugs: FALCON-1359
    https://issues.apache.org/jira/browse/FALCON-1359


Repository: falcon-git


Description
-------

Output of feed instance listing api is not properly vertically aligned in the CLI.


Diffs
-----

  client/src/main/java/org/apache/falcon/ResponseHelper.java ec6604d 

Diff: https://reviews.apache.org/r/37077/diff/


Testing
-------

Deployed and tested.


Thanks,

Ajay Yadava


Re: Review Request 37077: FALCON-1359 Fix output format of Feed Instance Listing API

Posted by sandeep samudrala <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37077/#review94110
-----------------------------------------------------------

Ship it!


Ship It!

- sandeep samudrala


On Aug. 4, 2015, 2:50 p.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37077/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2015, 2:50 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1359
>     https://issues.apache.org/jira/browse/FALCON-1359
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Output of feed instance listing api is not properly vertically aligned in the CLI.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/ResponseHelper.java ec6604d 
> 
> Diff: https://reviews.apache.org/r/37077/diff/
> 
> 
> Testing
> -------
> 
> Deployed and tested.
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>


Re: Review Request 37077: FALCON-1359 Fix output format of Feed Instance Listing API

Posted by sandeep samudrala <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37077/#review94541
-----------------------------------------------------------

Ship it!


Ship It!

- sandeep samudrala


On Aug. 7, 2015, 2:26 p.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37077/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2015, 2:26 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1359
>     https://issues.apache.org/jira/browse/FALCON-1359
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Output of feed instance listing api is not properly vertically aligned in the CLI.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/ResponseHelper.java 2df3e00 
> 
> Diff: https://reviews.apache.org/r/37077/diff/
> 
> 
> Testing
> -------
> 
> Deployed and tested.
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>


Re: Review Request 37077: FALCON-1359 Fix output format of Feed Instance Listing API

Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37077/
-----------------------------------------------------------

(Updated Aug. 7, 2015, 2:26 p.m.)


Review request for Falcon.


Changes
-------

Implemented using %s instead of \t as per code review comments.


Bugs: FALCON-1359
    https://issues.apache.org/jira/browse/FALCON-1359


Repository: falcon-git


Description
-------

Output of feed instance listing api is not properly vertically aligned in the CLI.


Diffs (updated)
-----

  client/src/main/java/org/apache/falcon/ResponseHelper.java 2df3e00 

Diff: https://reviews.apache.org/r/37077/diff/


Testing
-------

Deployed and tested.


Thanks,

Ajay Yadava