[GitHub] [hbase] ddupg commented on a change in pull request #2943: HBASE-25562 ReplicationSourceWALReader log and handle exception immediately without retrying

[GitBox <gi...@apache.org>]

ddupg commented on a change in pull request #2943:
URL: https://github.com/apache/hbase/pull/2943#discussion_r578107523



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java
##########
@@ -148,12 +148,10 @@ public void run() {
           }
         }
       } catch (IOException e) { // stream related
+        LOG.error("Failed to read stream of replication entries", e);

Review comment:
       Thanks for reviewing.
   In our use, we got a case, the read position is greater than the WAL length, reader thread stuck in retry and no log. We haven't figure out the case, maybe it's a bug. So hope to print out the error log in time first when unexpected IOE happens.
   So how about logging only when IOE can’t be handled by `handleEofException`? Only log in unexpected cases?
   I just fixed it, please take another review.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org